Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread not being marked as read #24442

Closed
Tracked by #24392
andybalaam opened this issue Feb 6, 2023 · 9 comments
Closed
Tracked by #24392

Thread not being marked as read #24442

andybalaam opened this issue Feb 6, 2023 · 9 comments
Labels
A-Notifications A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@andybalaam
Copy link
Member

Steps to reproduce

  1. In a room with a thread
  2. Open the thread and read it
  3. Go to the all threads view - see the dot indicates that the thread is unread
  4. Re-open the thread
  5. Still not marked as read

Outcome

What did you expect?

I expected the thread to be marked as read

What happened instead?

It was not marked as read

Operating system

Ubuntu 22.04

Browser information

Firefox 109.0.1

URL for webapp

https://develop.element.io

Application version

Element version: e047e5d-react-a756b33fe912-js-2a363598dd98 Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

Yes

@andybalaam
Copy link
Member Author

Probably related to #23685 but not the same because it persists after I open the room.

@weeman1337
Copy link
Contributor

weeman1337 commented Feb 8, 2023

Also found a thread not being marked as read.
More about it in the rageshake.

For me this happened when the last event is a reaction to a previous (not the last) event in the thread timeline.

@SimonBrandner SimonBrandner added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely A-Threads labels Feb 8, 2023
@Walnussbaer
Copy link

Walnussbaer commented Feb 9, 2023

We experience this problem as well in our company. But not every time when someone posts something in a thread, just sometimes.

@MadLittleMods
Copy link
Contributor

Reproduced this issue today (rageshake logs)

Room list shows 1 unread message:

Thread list shows a dot:

Clicking on the thread and scrolling up and down has no effect:

/devtools -> Notification debug output shows that I have read all of the messages in the thread. The last message is an edit to the thread parent.

Room status

  • Room unread status: Grey, count: 1
  • Notification state is all_messages
  • Room is not encrypted 🚨

Main timeline

  • Total: 0
  • Highlight: 0
  • Dot: false

Threads timeline

  • Thread Id: $ANtMWAyX_RzChi195z7EHmQN6cs5g687RGlNQEzJeT4
    • Total: 1
    • Highlight: 0
    • Dot: false
    • User read up to: $nDgVIqgPXwtO2O1pQLdh6B2sZ_YrsS4I0rVfHt-i4I0
    • Last event:
      • ID: $nDgVIqgPXwtO2O1pQLdh6B2sZ_YrsS4I0rVfHt-i4I0
      • Type: m.room.message
      • Sender: @aw-bib:matrix.org

@florianduros
Copy link
Member

Reproduced in:

Room ID: !UCBgpJmTgAHYpcJBoh:matrix.org
Event ID: $7ZIMSb1MgmlVH_d1iEUAn9z-u3n_BN70AXHi1cRwDh4
Thread root ID: $hVLFDTGWWhDaqgku1JoX8uUrKcrZWF5DfC3N8vq-trw

Event

{
  "room_id": "!UCBgpJmTgAHYpcJBoh:matrix.org",
  "type": "m.room.message",
  "content": {
    "msgtype": "m.text",
    "body": ...
  }
}

@Johennes Johennes changed the title Thread not being marked as read Stuck notifications: Thread not being marked as read Feb 27, 2023
@justjanne justjanne added X-Cannot-Reproduce X-Needs-Info This issue is blocked awaiting information from the reporter labels Feb 27, 2023
@MadLittleMods MadLittleMods removed X-Needs-Info This issue is blocked awaiting information from the reporter X-Cannot-Reproduce labels Mar 15, 2023
@MadLittleMods
Copy link
Contributor

@justjanne It feels really odd to add X-Cannot-Reproduce and X-Needs-Info for something that 4 Element employees (some on the Web team) have bothered to report. We've provided all information possible with the current tools. If more info is needed to reproduce, then we should add some better logging/tracing to the app for this so we can get you the info needed to reproduce locally yourself. I understand you technically can't reproduce yourself or at least consistently to figure out what's going wrong but it feels like that label is more for issues we're not really confident in.

@justjanne
Copy link
Contributor

@MadLittleMods I labeled it cannot reproduce/needs info because I don't have enough info to reproduce it reliably or write a test to reproduce it.

Just because the labels are attached doesn't mean the issue is invalid — it definitely is valid, otherwise the issue wouldn't remain open and on the top of my todo list.

In fact, I've been spending pretty much my entire dev time in the past weeks on these issues.

Part of why the labels are attached (and why I'm not investigating further on this specific issue right now) is that I've discovered a solution that would solve and/or fix multiple issues at the same time, and I'd like to see how that solution affects this issue before I investigate further.

@JimKillock
Copy link

JimKillock commented Mar 20, 2023

FWIW our team at Open Rights Group are having this issue; good to see it is being looked at. I will ask our tech team to see if they can supply information to help hunt it down altho it sounds like it is very tricky.

In our case, the issue appears to be that threads are often marked as read on the client, but when the client is reopened, or the chat is opened by the same user on another device, the threads revert to unread.

@Johennes Johennes changed the title Stuck notifications: Thread not being marked as read Thread not being marked as read May 5, 2023
@t3chguy
Copy link
Member

t3chguy commented Aug 8, 2023

This is believed to have been fixed in the work over the past 2 months, if you are still experiencing it on latest versions of Element Web/Desktop please open a new issue with fresh logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

9 participants