Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when recording voice messages #2184

Closed
stefanceriu opened this issue Nov 29, 2023 · 0 comments · Fixed by #2188
Closed

Crash when recording voice messages #2184

stefanceriu opened this issue Nov 29, 2023 · 0 comments · Fixed by #2188
Assignees
@nimau
Labels
A-Voice-Message O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Team: Element X Feature

Comments

@stefanceriu
Copy link
Member

stefanceriu commented Nov 29, 2023 •
edited
Loading

It seems that the OGGEncoder crashes with an EXC_BREAKPOINT on init when created from OGGConverter.convertM4aFileToOpusOG

The logs aren't particularly interesting

2023-11-28T11:37:14.444886Z  INFO elementx: cleaning up the audio engine | AudioRecorder.swift:220 | spans: root
2023-11-28T11:37:14.500312Z  INFO elementx: releasing audio session | AudioRecorder.swift:131 | spans: root
2023-11-28T11:37:14.638238Z  INFO elementx: audio recorder stopped | AudioRecorder.swift:214 | spans: root
2023-11-28T11:37:14.640119Z  INFO elementx: audio recorder did stop recording | VoiceMessageRecorder.swift:227 | spans: root
2023-11-28T11:37:14.640847Z  INFO elementx: finalize audio recording | VoiceMessageRecorder.swift:249 | spans: root

Original report here https://github.com/vector-im/element-x-ios-rageshakes/issues/1141

https://sentry.tools.element.io/organizations/element/issues/90914/events/7300a8de5eb44e889c2acc589e10a1d9/?project=44&referrer=issue-list
@stefanceriu stefanceriu added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Voice-Message labels Nov 29, 2023
@nimau nimau mentioned this issue Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nimau nimau

Labels
A-Voice-Message O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Team: Element X Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: added sample rate conversion for recording voice messages element-hq/element-x-ios
3 participants
@kittykat @stefanceriu @nimau