Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validate-lfs.sh check from Android. #203

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 21, 2022

Copied across from the EA workflow and script.

Will test separately once merged with a fresh clone that didn't git lfs install

@github-actions
Copy link

github-actions bot commented Sep 21, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against f00bcb7

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pixlwave pixlwave requested review from a team and stefanceriu and removed request for a team September 21, 2022 17:39
@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Aq6Hdn

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 11.97% // Head: 11.97% // No change to project coverage 👍

Coverage data is based on head (f00bcb7) compared to base (8462862).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #203   +/-   ##
========================================
  Coverage    11.97%   11.97%           
========================================
  Files          208      208           
  Lines        14146    14146           
  Branches      6844     6844           
========================================
  Hits          1694     1694           
  Misses       12412    12412           
  Partials        40       40           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff although I was hoping we could have it as a git pre-commit hook as well. Probably not that important, this is not something we'll encounter very often

@pixlwave
Copy link
Member Author

I was hoping we could have it as a git pre-commit hook as well.

Sadly this would work the same way as LFS and only be available for whoever added the hook (at which point they should just git lfs install instead). This seems to be a very intentional choice in git 🤷‍♂️

@pixlwave pixlwave merged commit e7eeac0 into develop Sep 22, 2022
@pixlwave pixlwave deleted the doug/lfs-checks branch September 22, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants