Skip to content

Commit

Permalink
chore(ci): Pin ubuntu versions in GHA
Browse files Browse the repository at this point in the history
`ubuntu-latest` recently changed to 24.04 for some workflows which caused unexpected breakages.
I think it is better to pin to a specific version and upgrade as-needed rather than track latest and
have it break unexpectedly.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
  • Loading branch information
jszwedko committed Dec 16, 2024
1 parent d4fc91f commit 329cc3e
Show file tree
Hide file tree
Showing 23 changed files with 30 additions and 30 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:

jobs:
validate-changelog:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: github.event_name == 'pull_request'
env:
PR_HAS_LABEL: ${{ contains( github.event.pull_request.labels.*.name, 'no-changelog') }}
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
check-changelog:
name: Changelog
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs: validate-changelog
if: always()
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/changes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ jobs:
# Detects changes that are specific to integration tests
int_tests:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
if: ${{ inputs.int_tests }}
outputs:
Expand Down Expand Up @@ -254,7 +254,7 @@ jobs:

# Detects changes that are specific to e2e tests
e2e_tests:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
if: ${{ inputs.e2e_tests }}
outputs:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-integration-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ env:
jobs:
prep-pr:
name: (PR review) Signal pending to PR
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
if: startsWith(github.event.review.body, '/ci-run-integration') || contains(github.event.review.body, '/ci-run-all')
steps:
Expand Down Expand Up @@ -496,7 +496,7 @@ jobs:

update-pr-status:
name: Signal result to PR
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
needs:
- integration-tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-review-trigger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ env:
jobs:
validate:
name: Validate review
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
if: |
startsWith(github.event.review.body, '/ci-run-all')
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ permissions:

jobs:
test-cli:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
timeout-minutes: 15
env:
CARGO_INCREMENTAL: 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/component_features.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ permissions:
jobs:
check-component-features:
# use free tier on schedule and 8 core to expedite results on demand invocation
runs-on: ${{ github.event_name == 'schedule' && 'ubuntu-latest' || 'ubuntu-20.04-8core' }}
runs-on: ${{ github.event_name == 'schedule' && 'ubuntu-20.04' || 'ubuntu-20.04-8core' }}
if: github.event_name == 'pull_request_review' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule'
steps:
- name: (PR review) Set latest commit status as pending
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create_preview_sites.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ permissions:

jobs:
create_preview_site:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
steps:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cross.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ permissions:
jobs:
cross-linux:
name: Cross - ${{ matrix.target }}
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
timeout-minutes: 45
env:
CARGO_INCREMENTAL: 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deny.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ permissions:

jobs:
test-deny:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
timeout-minutes: 15
env:
CARGO_INCREMENTAL: 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:

e2e-test-suite:
name: E2E Test Suite
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
if: always()
needs: e2e-tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gardener_issue_comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
jobs:
move-to-backlog:
name: Move issues back to Gardener project board Triage
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
if: ${{ !github.event.issue.pull_request }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gardener_open_issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
add-to-project:
name: Add issue to Gardener project board
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
steps:
- uses: actions/add-to-project@v1.0.2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gardener_open_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
jobs:
add-contributor-to-project:
name: Add contributor PR to Gardener project board
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
if: ${{ github.actor != 'dependabot[bot]' }}
steps:
Expand All @@ -33,7 +33,7 @@ jobs:
github-token: ${{ secrets.GH_PROJECT_PAT }}
add-dependabot-to-project:
name: Add dependabot PR to Gardener project board
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
if: ${{ github.actor == 'dependabot[bot]' }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gardener_remove_waiting_author.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
remove_label:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ jobs:

integration-test-suite:
name: Integration Test Suite
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
if: always()
needs:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/k8s_e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ jobs:
# See https://git.luolix.topmunity/t/feature-request-and-use-case-example-to-allow-matrix-in-if-s/126067
compute-k8s-test-plan:
name: Compute K8s test plan
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
needs: changes
# Run this job even if `changes` job is skipped
Expand Down Expand Up @@ -234,7 +234,7 @@ jobs:

final-result:
name: K8s E2E Suite
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
needs:
- changes
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/msrv.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:

jobs:
check-msrv:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/preview_site_trigger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
approval_check:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
if: ${{ contains(github.head_ref, 'website') }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/protobuf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ concurrency:

jobs:
validate-protos:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
steps:
# Run `git checkout`
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ env:
jobs:

resolve-inputs:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
outputs:
baseline-sha: ${{ steps.set_and_validate_shas.outputs.BASELINE_SHA }}
comparison-sha: ${{ steps.set_and_validate_shas.outputs.COMPARISON_SHA }}
Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
# Only run this workflow if files changed in areas that could possibly introduce a regression.
check-source-changed:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
needs: resolve-inputs
outputs:
Expand Down Expand Up @@ -172,7 +172,7 @@ jobs:
echo "SOURCE_CHANGED=${SOURCE_CHANGED}" >> $GITHUB_OUTPUT
should-run-gate:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs: check-source-changed
if: ${{ needs.check-source-changed.outputs.source_changed }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scorecard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ permissions: read-all
jobs:
analysis:
name: Scorecard analysis
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
permissions:
# Needed to upload the results to code-scanning dashboard.
security-events: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/semantic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
jobs:
main:
name: Check Semantic PR
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: amannn/action-semantic-pull-request@v5
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/spelling.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
security-events: write
outputs:
followup: ${{ steps.spelling.outputs.followup }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
if: "contains(github.event_name, 'pull_request') || github.event_name == 'push'"
concurrency:
Expand Down

0 comments on commit 329cc3e

Please sign in to comment.