fix: use rstest in generate command tests (vs wrong usage of `pro…

…ptest`) (#18365)

* fix: wrong usage of proptest, replace with rstest

* add rstest to the dictionary

.github/actions/spelling/allow.txt

@@ -404,6 +404,7 @@ rootfs
 roundrobin
 rpmbuild
 rpms
+rstest
 rsyslog
 rsyslogd
 servlet

Cargo.toml

@@ -367,6 +367,7 @@ proptest = "1.2"
 quickcheck = "1.0.3"
 lookup = { package = "vector-lookup", path = "lib/vector-lookup", features = ["test"] }
 reqwest = { version = "0.11", features = ["json"] }
+rstest = {version = "0.18.2"}
 tempfile = "3.6.0"
 test-generator = "0.3.1"
 tokio = { version = "1.32.0", features = ["test-util"] }

src/config/format.rs

@@ -74,16 +74,6 @@ where
 #[cfg(test)]
 mod tests {
     use super::*;
-    use proptest::prelude::*;
-
-    impl Arbitrary for Format {
-        type Parameters = ();
-        fn arbitrary_with(_args: Self::Parameters) -> Self::Strategy {
-            prop_oneof![Just(Format::Toml), Just(Format::Json), Just(Format::Yaml),].boxed()
-        }
-
-        type Strategy = BoxedStrategy<Self>;
-    }
 
     /// This test ensures the logic to guess file format from the file path
     /// works correctly.

src/generate.rs

@@ -392,7 +392,7 @@ fn write_config(filepath: &Path, body: &str) -> Result<(), crate::Error> {
 mod tests {
     use super::*;
     use crate::config::ConfigBuilder;
-    use proptest::prelude::*;
+    use rstest::rstest;
 
     fn generate_and_deserialize(expression: String, format: Format) {
         let opts = Opts {
@@ -410,20 +410,22 @@ mod tests {
         }
     }
 
-    proptest! {
-        #[test]
-        fn generate_all(format in any::<Format>()) {
-            for name in SourceDescription::types() {
-                generate_and_deserialize(format!("{}//", name), format);
-            }
+    #[rstest]
+    #[case(Format::Toml)]
+    #[case(Format::Json)]
+    #[case(Format::Yaml)]
+    #[test]
+    fn generate_all(#[case] format: Format) {
+        for name in SourceDescription::types() {
+            generate_and_deserialize(format!("{}//", name), format);
+        }
 
-            for name in TransformDescription::types() {
-                generate_and_deserialize(format!("/{}/", name), format);
-            }
+        for name in TransformDescription::types() {
+            generate_and_deserialize(format!("/{}/", name), format);
+        }
 
-            for name in SinkDescription::types() {
-                generate_and_deserialize(format!("//{}", name), format);
-            }
+        for name in SinkDescription::types() {
+            generate_and_deserialize(format!("//{}", name), format);
         }
     }