Skip to content

Commit

Permalink
chore(observability): deprecate obsolete http metrics (#18972)
Browse files Browse the repository at this point in the history
* OPW-94 deprecate obsolete http metrics

* feedback

* feedback

* fmt

* Update DEPRECATIONS.md
  • Loading branch information
dsmith3197 authored Nov 3, 2023
1 parent 8ba28e0 commit f33dce2
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
1 change: 1 addition & 0 deletions docs/DEPRECATIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ For example:
## To be removed

- datadog_v1_metrics v0.35.0 Support for `v1` series endpoint in the `datadog_metrics` sink should be removed.
- http_internal_metrics v0.35.0 `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics should be removed.
15 changes: 15 additions & 0 deletions website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ Vector's 0.34.0 release includes **breaking changes**:
1. [Blackhole sink no longer reports by default](#blackhole-sink-reporting)
1. [Remove direct OpenSSL legacy provider support](#openssl-legacy-provider)

and **deprecations**:

1. [Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics](#deprecate-obsolete-http-metrics)

We cover them below to help you upgrade quickly:

Expand Down Expand Up @@ -101,3 +104,15 @@ flag was deprecated in v0.33.0.

The legacy OpenSSL provider (and other providers than the default provider) can still be enabled if
desired through [options in OpenSSL's configuration](/docs/reference/configuration/tls)

### Deprecations

#### Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics {#deprecate-obsolete-http-metrics}

The `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics are removed in the 0.35.0 release.

| Deprecated metric | Replacement metric | Affected components |
|-----------------------------|-------------------------------------|------------------------------------------------------------------------------------------|
| requests_completed_total | http_client_responses_total | apache metrics, aws ecs metrics, http client, prometheus remote write, prometheus scrape |
| request_duration_seconds | http_client_response_rtt_seconds | apache metrics, aws ecs metrics, http client, prometheus remote write, prometheus scrape |
| requests_received_total | http_server_requests_received_total | aws kinesis firehose, heroku logplex, prometheus exporter, splunk hec |

0 comments on commit f33dce2

Please sign in to comment.