Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add support for amazonlinux:1, centos:7, and ubuntu:14.04 #13183

Closed
jszwedko opened this issue Jun 16, 2022 · 10 comments · Fixed by #15695
Closed

Re-add support for amazonlinux:1, centos:7, and ubuntu:14.04 #13183

jszwedko opened this issue Jun 16, 2022 · 10 comments · Fixed by #15695
Assignees
@bruceg
Labels
domain: platforms Anything related to Vector's supported platforms domain: releasing Anything related to releasing Vector platform: amazon-linux Anything `amazon-linux` platform related platform: ubuntu Anything `ubuntu` platform related

Comments

@jszwedko
Copy link
Member

jszwedko commented Jun 16, 2022 •
edited
Loading

The newer cross images build on Ubuntu 16.04 which ends up linking against a newer libc and libc++ than is available on ubuntu:14.04, centos:7, amazonlinux:1. We dropped the release tests for them in #13146 to unblock the nightly build, but we should explore re-adding them by linking against older versions of libc/libc++ since these OS's are not yet EOL.
@jszwedko jszwedko added platform: ubuntu Anything `ubuntu` platform related domain: platforms Anything related to Vector's supported platforms platform: amazon-linux Anything `amazon-linux` platform related domain: releasing Anything related to releasing Vector labels Jun 16, 2022
@jszwedko jszwedko added this to the Vector v0.23.0 milestone Jun 16, 2022
@jszwedko jszwedko changed the title Re-add support for amazonlinux:1 and ubuntu:14.04 Re-add support for amazonlinux:1, centos:7, and ubuntu:14.04 Jul 1, 2022
This was referenced Jul 26, 2022
Closed
Open
@darjeeling
Copy link

IMHO, there is still many centos 7 servers alive.

@leandrojmp
Copy link

Is this targetting any release at the moment?

I was looking if this another issue was already merged in a new version to update my vector node and just saw that version 0.23+ does not run on CentOS 7, which I'm still using.

Building from source on a CentOS 7 machine works as a workaround?

@jszwedko
Copy link
Member Author

Hi @leandrojmp !

Unfortunately we haven't been able to fix this quite yet. However, yes, building on a CentOS 7 machine should work to create a binary linked against the older version of libc.

@jszwedko jszwedko removed this from the Vector v0.25.0 milestone Sep 6, 2022
@abh
Copy link

abh commented Oct 7, 2022

If this doesn't have a milestone anymore, maybe at least update the documentation to say that CentOS 7 isn't supported? https://vector.dev/docs/setup/installation/operating-systems/centos/

@darjeeling
Copy link

@abh I agree with that. at least need documentation update

@ilikejam ilikejam mentioned this issue Nov 25, 2022
Closed
@bruceg bruceg self-assigned this Dec 12, 2022
@flyingflo
Copy link

Looks like cross-rs got a special target x86_64-unknown-linux-gnu:centos for CentOS7 with glibc 2.17. That could solve this issue, if I understand that correctly!?
cross-rs/cross@80891e7

apollo13 added a commit to apollo13/vector that referenced this issue Dec 22, 2022
@apollo13
enhancement(x86_64 platform): Build packages with an older glibc to r…
d518ffc 
…eenable centos7 and others.

Fixes vectordotdev#13183
@apollo13 apollo13 mentioned this issue Dec 22, 2022
Merged
@apollo13
Copy link
Contributor

I have added PR that addresses this issue. I see @bruceg assigned this to himself, I hope we didn't do the work in parallel now :)

apollo13 added a commit to apollo13/vector that referenced this issue Dec 22, 2022
@apollo13
enhancement(x86_64 platform): Build packages with an older glibc to r…
09393d6 
…eenable centos7 and others.

Fixes vectordotdev#13183
apollo13 added a commit to apollo13/vector that referenced this issue Dec 22, 2022
@apollo13
enhancement(x86_64 platform): Build packages with an older glibc to r…
84783cc 
…eenable centos7 and others.

Fixes vectordotdev#13183
apollo13 added a commit to apollo13/vector that referenced this issue Dec 22, 2022
@apollo13
enhancement(x86_64 platform): Build packages with an older glibc to r…
fd38f59 
…eenable centos7 and others.

Fixes vectordotdev#13183
@bruceg
Copy link
Member

bruceg commented Dec 22, 2022

I have added PR that addresses this issue. I see @bruceg assigned this to himself, I hope we didn't do the work in parallel now :)

Thanks for taking this up @apollo13. I had taken a look at it before @flyingflo pointed out that cross can do at least some of the work for us, and then moved back to other work, so no, we're not duplicating work here.

bruceg pushed a commit that referenced this issue Dec 22, 2022
@apollo13
chore(x86_64 platform): Build packages with an older glibc to reenabl…
162c7fe 
…e centos7 and others. (#15695)

enhancement(x86_64 platform): Build packages with an older glibc to reenable centos7 and others.

Fixes #13183
@aaronjheng
Copy link

Can we get a patch release for this?

@jszwedko
Copy link
Member Author

jszwedko commented Jan 5, 2023

Can we get a patch release for this?

0.27.0 will be going out in a week and a half so I think we'll likely just loop it into that release.

@lambdaq lambdaq mentioned this issue Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bruceg bruceg

Labels
domain: platforms Anything related to Vector's supported platforms domain: releasing Anything related to releasing Vector platform: amazon-linux Anything `amazon-linux` platform related platform: ubuntu Anything `ubuntu` platform related
Projects
None yet
Milestone
No milestone
8 participants
@abh @darjeeling @apollo13 @jszwedko @leandrojmp @bruceg @aaronjheng @flyingflo