Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(new_relic sink): tags not sent with metrics, leading to unwanted aggregation/downsampling #13377

Closed
lukasmrtvy opened this issue Jun 29, 2022 · 5 comments · Fixed by #18151
Labels
provider: new relic Anything `new relic` service provider related sink: new_relic Anything `new_relic` sink related type: bug A code related bug.

Comments

@lukasmrtvy
Copy link

lukasmrtvy commented Jun 29, 2022

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

NewRelic sink ( https://vector.dev/docs/reference/configuration/sinks/new_relic/ ) does not support .tags object, but instead of .tags, NR supports .attributes ( https://docs.newrelic.com/docs/data-apis/ingest-apis/metric-api/report-metrics-metric-api/ )

Remapping .tags to .attributes via VRL does not work.

Same metric from different sources ( where for example .tags.appname will be different ) shipped via the same Vector instance will be mixed in NR timeseries data. Querying metric based on .tags.appname metadata value would be impossible then.

Configuration

No response

Version

timberio/vector:0.22.2-debian image

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response

@lukasmrtvy lukasmrtvy added the type: bug A code related bug. label Jun 29, 2022
@jszwedko jszwedko added provider: new relic Anything `new relic` service provider related sink: new_relic Anything `new_relic` sink related labels Jun 29, 2022
@tobz tobz changed the title NR sink does not support .tags object, Sink can not work for more than 1 metric with different metadata bug(new_relic sink): tags not sent with metrics, leading to unwanted aggregation/downsampling Aug 1, 2022
@tobz
Copy link
Contributor

tobz commented Aug 1, 2022

Additionally, from taking a look at the new_relic sink, it appears that we don't send the metric type along, and that we don't handle distributions, either.

I'll open a separate ticket to track the lack of full metric support.

@tobz
Copy link
Contributor

tobz commented Aug 1, 2022

Opened #13781 to track further improvements to the metrics support for the new_relic sink.

@asllop
Copy link
Contributor

asllop commented Sep 15, 2022

@jszwedko I'm currently working on this issue, could you assign it to me?

@spencergilbert
Copy link
Contributor

Thanks for the contribution @asllop!

@asllop
Copy link
Contributor

asllop commented Sep 16, 2022

@tobz distribution metrics are not actually supported by the New Relic Metric API. Internally, New Relic can handle this type of metrics (https://docs.newrelic.com/docs/data-apis/understand-data/metric-data/metric-data-type/), but the API only allows injecting gauge, count and summary metrics (https://docs.newrelic.com/docs/data-apis/ingest-apis/metric-api/report-metrics-metric-api/#send-metric-data). And regarding count metrics, pleas check out this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider: new relic Anything `new relic` service provider related sink: new_relic Anything `new_relic` sink related type: bug A code related bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants