Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(new_relic sink): add distribution support and send metric type #13781

Closed
2 of 3 tasks
tobz opened this issue Aug 1, 2022 · 2 comments · Fixed by #18151
Closed
2 of 3 tasks

chore(new_relic sink): add distribution support and send metric type #13781

tobz opened this issue Aug 1, 2022 · 2 comments · Fixed by #18151
Labels
Epic Larger, user-centric issue that contains multiple sub-issues provider: new relic Anything `new relic` service provider related sink: new_relic Anything `new_relic` sink related type: feature A value-adding code addition that introduce new functionality.

Comments

@tobz
Copy link
Contributor

tobz commented Aug 1, 2022 •
edited by jszwedko
Loading

In the new_relic sink, among other issues, we currently do not support distributions even though they're supported on the New Relic side. Additionally, we don't send the metric type, which causes all metrics -- counter or gauge -- to be treated as gauges.

We should:
@tobz tobz added provider: new relic Anything `new relic` service provider related sink: new_relic Anything `new_relic` sink related labels Aug 1, 2022
@tobz tobz mentioned this issue Aug 1, 2022
Closed
@jszwedko
Copy link
Member

jszwedko commented Aug 1, 2022

cc/ @asllop . I know you contributed the initial new_relic sink so just flagging this in case it is something you are interested to contribute.

@jszwedko jszwedko added the type: feature A value-adding code addition that introduce new functionality. label Aug 1, 2022
@asllop
Copy link
Contributor

asllop commented Aug 2, 2022

@jszwedko yes I am! Also interested in #13377, I just don't know when I'm gonna have time to contribute.

@jszwedko jszwedko added the Epic Larger, user-centric issue that contains multiple sub-issues label Aug 9, 2022
@asllop asllop mentioned this issue Sep 23, 2022
Closed
@jszwedko jszwedko mentioned this issue Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Epic Larger, user-centric issue that contains multiple sub-issues provider: new relic Anything `new relic` service provider related sink: new_relic Anything `new_relic` sink related type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(new_relic sink): Multiple fixes related to metrics vectordotdev/vector
3 participants
@tobz @jszwedko @asllop