Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vrl/docs: parse_regex_all list incorrect failure reason #21883

Closed
mdeltito opened this issue Nov 25, 2024 · 0 comments · Fixed by #21884
Closed

vrl/docs: parse_regex_all list incorrect failure reason #21883

mdeltito opened this issue Nov 25, 2024 · 0 comments · Fixed by #21884
Labels
type: bug A code related bug.

Comments

@mdeltito
Copy link
Contributor

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

The docs say parse_regex_all is fallible when

value fails to parse using the provided pattern

Unlike parse_regex, however, this function only checks that value is the Value::Bytes variant. It returns an empty array when there are no matches.

Configuration

No response

Version

n/a

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response
@mdeltito mdeltito added the type: bug A code related bug. label Nov 25, 2024
mdeltito added a commit to mdeltito/vector that referenced this issue Nov 25, 2024
@mdeltito
docs: specify correct failure reason for parse_regex_all fallibility
279cff3 
Corrects the failure reason for `parse_regex_all`, which has different
semantics from `parse_regex`.

closes vectordotdev#21883
@mdeltito mdeltito mentioned this issue Nov 25, 2024
Merged
10 tasks
mdeltito added a commit to mdeltito/vector that referenced this issue Nov 26, 2024
@mdeltito
docs: remove incorrect failure reason for parse_regex_all fallibility
4966608 
Removes the failure reason for `parse_regex_all`, which has different
semantics from `parse_regex` when there is no match.

closes vectordotdev#21883
github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2024
@mdeltito
docs(external): remove incorrect failure reason for parse_regex_all f…
c3d91af 
…allibility (#21884)

docs: remove incorrect  failure reason for parse_regex_all fallibility

Removes the failure reason for `parse_regex_all`, which has different
semantics from `parse_regex` when there is no match.

closes #21883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A code related bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(external): remove incorrect failure reason for parse_regex_all fallibility mdeltito/vector
1 participant
@mdeltito