Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies to tokio 1.0 #5175

Closed
28 tasks
fanatid opened this issue Nov 22, 2020 · 9 comments
Closed
28 tasks

Upgrade dependencies to tokio 1.0 #5175

fanatid opened this issue Nov 22, 2020 · 9 comments
Assignees
Labels
meta: blocked Anything that is blocked to the point where it cannot be worked on. type: task Generic non-code related tasks

Comments

@fanatid
Copy link
Contributor

fanatid commented Nov 22, 2020

tokio:0.3 was released a month ago. dependabot creates pull requests (like #5158) with dependencies which were already updated, but we can not easily merge them. I did not research yet about any compatibility layer, maybe we will need to update everything at once or it will be possible to update crates independently, not sure. This is only a tracking issue with dependencies status regarding their update to new tokio.

tokio:0.3 list (outdated because we will upgrade to tokio:1.0 and skip tokio:0.3):

**Valid on `11/30/2020`:**

Will create new list (with tokio:1.0) when we close #5103.

@fanatid fanatid added the type: task Generic non-code related tasks label Nov 22, 2020
@binarylogic
Copy link
Contributor

@kirillt it might be worth opening issues on each repo first if they don't already exist. Would you mind doing that?

@kirillt
Copy link
Contributor

kirillt commented Nov 29, 2020

@fanatid :)

@fanatid
Copy link
Contributor Author

fanatid commented Nov 30, 2020

@binarylogic I updated the issue (tracking issues added). Before we start work on tokio upgrade I think we need to finish with futures: #5103 (maybe add blocking tag here?).

@binarylogic
Copy link
Contributor

Thanks @fanatid, sounds good.

@jamtur01 jamtur01 removed this from the 2020-12-07: Nanite Repair System milestone Dec 5, 2020
@fanatid fanatid added the meta: blocked Anything that is blocked to the point where it cannot be worked on. label Dec 19, 2020
@juchiast
Copy link
Contributor

tokio 1.0 is out!

@fanatid
Copy link
Contributor Author

fanatid commented Dec 24, 2020

Yep, maybe we will skip 0.3 and switch directly to 1.0. I'm not sure that all listed crates above will support 0.3...
https://tokio.rs/blog/2020-12-tokio-1-0

@fanatid fanatid changed the title Upgrade tokio to 0.3 Upgrade tokio to 0.3 (or 1.0?) Dec 24, 2020
@juchiast
Copy link
Contributor

Yeah, hyper already released 1.0-compatible version, and I think warp will be updated soon.

@jamtur01
Copy link
Contributor

jamtur01 commented Jan 9, 2021

Look like go-auth has released 0.9.0 which upgrades to tokio 1.0

@fanatid
Copy link
Contributor Author

fanatid commented Jan 12, 2021

@lukesteensen started work on this in #5872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: blocked Anything that is blocked to the point where it cannot be worked on. type: task Generic non-code related tasks
Projects
None yet
Development

No branches or pull requests

6 participants