Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka sink: use signal instead timeout on full buffer #6057

Closed
fanatid opened this issue Jan 14, 2021 · 2 comments
Closed

Kafka sink: use signal instead timeout on full buffer #6057

fanatid opened this issue Jan 14, 2021 · 2 comments
Labels
sink: kafka Anything `kafka` sink related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@fanatid
Copy link
Contributor

fanatid commented Jan 14, 2021

Initially kafka sink was changed to use a timeout in #4846. In the same pull request @lukesteensen proposed to use signal instead timeout (#4846 (comment)). I changed timeout to signal in #5007.
Unfortunately, this caused significant performance decrease (#5007 (comment)), so Luke reverted #5007 in #5900 and proposed to use notify_waiters from tokio:1.0.

Currently blocked by #5175
@fanatid fanatid added sink: kafka Anything `kafka` sink related type: enhancement A value-adding code change that enhances its existing functionality. meta: blocked Anything that is blocked to the point where it cannot be worked on. labels Jan 14, 2021
@fanatid fanatid changed the title Use signal instead timeout on full buffer Kafka sink: use signal instead timeout on full buffer Jan 14, 2021
@binarylogic binarylogic modified the milestone: 2021-02-22 - Scottish Deerhound Feb 22, 2021
@pablosichert pablosichert removed the meta: blocked Anything that is blocked to the point where it cannot be worked on. label Apr 19, 2021
@jszwedko
Copy link
Member

Noting that #5175 is done so this work could seemingly be done.

@jszwedko
Copy link
Member

I'll close this, though, since it seems like technical debt without user-facing impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sink: kafka Anything `kafka` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jszwedko @binarylogic @fanatid @pablosichert