Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config): Make example in guides/level-up/managing-complex-configs work with Vector 0.18 #10168

Conversation

ypid-geberit
Copy link
Contributor

I am opening this PR to help new users getting into Vector. I actually wanted to fix https://vector.dev/docs/reference/configuration/sinks/socket/#example-configurations, but I assume that is auto generated with all the required options. I don’t know how that can be fixed. address and path are not required in all cases, depending on mode.

@bits-bot
Copy link

bits-bot commented Nov 24, 2021

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Nov 24, 2021

✔️ Deploy Preview for vector-project ready!

🔨 Explore the source changes: 64c02f1

🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/619e2f5aff984e000732acc5

😎 Browse the preview: https://deploy-preview-10168--vector-project.netlify.app

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ypid-geberit !

Regarding the generated examples showing path and address for the socket source even though they are required differently depending on the mode is something we trying to address by replacing the generated examples with hand-written examples. #9870 was the first stab at it, but we need to revisit it.

@jszwedko jszwedko merged commit b73de9f into vectordotdev:master Nov 24, 2021
jszwedko pushed a commit that referenced this pull request Nov 24, 2021
…s work with Vector 0.18 (#10168)

* docs: For sources in tcp/udp mode, the path param does not make sense

It is not invalid as of 0.18 but should be. At least lets stop giving
such examples.

* docs: Fix typo

* docs: Fix example config: encoding.codec is required now for console sink
@ypid-geberit
Copy link
Contributor Author

Thanks for merging and linking the other PR. Works for me. Lets improve the docs one step after the other :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants