-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(vrl): Reduce VRL core such that it doesn't have any other dependencies to VRL #11492
Conversation
Signed-off-by: Pablo Sichert <mail@pablosichert.com>
Signed-off-by: Pablo Sichert <mail@pablosichert.com>
Signed-off-by: Pablo Sichert <mail@pablosichert.com>
✔️ Deploy Preview for vector-project ready! 🔨 Explore the source changes: b858989 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/62150245673a260007149ba7 😎 Browse the preview: https://deploy-preview-11492--vector-project.netlify.app |
Soak Test ResultsBaseline: fb44580 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±5%: Fine details of change detection per experiment.
Fine details of each soak run.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Pablo Sichert <mail@pablosichert.com>
Closes #10764.
This is an updated version of #10767. This PR however is a lot more straight-forward after the changes in #11296, #11365, and related PRs.
The main goal is to get access to
Target
,Value
andResolved
viavrl/core
without pulling in all of VRL and its parser and compiler.