fix(ci): Fix merge conflict for AWS auth changes #12344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vector-project canceled.
|
github-actions
bot
added
domain: sinks
spencergilbert
approved these changes
Apr 21, 2022
|
Technically the region is really only required for authentication mechanisms that rely on STS. We could refactor this later to not require region when other mechanisms (like static credentials) are used. |
bruceg
approved these changes
Apr 21, 2022
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
|
Force merging on unblock master. The previous commit passed sans one test and I verified the fix for that test locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a silent merge conflict between: efb5849 and f5391b6
Signed-off-by: Jesse Szwedko jesse@szwedko.me