fix(aws provider): Allow configuring the load timeout for AWS credentials #12422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ials Technically an enhancement, but it allows working around a regression in behavior (the default changing from 30s to 5s as part of the SDK upgrade) so marking as a fix. Closes: #12421 Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
✅ Deploy Preview for vector-project canceled.
|
github-actions
bot
added
the
domain: external docs
fuchsnj
approved these changes
Apr 26, 2022
src/aws/auth.rs
Outdated
| @@ -4,6 +4,10 @@ use aws_config::{ | |||
| use aws_types::{credentials::SharedCredentialsProvider, region::Region, Credentials}; | |||
| use serde::{Deserialize, Serialize}; | |||
|
|
|||
| // matches default load timeout from the SDK as of 0.10.1, but lets us confidently document the | |||
| // default rather than relying on the SDK default to not change | |||
| const DEFAULT_LOAD_TIMEOUT_SECS: u64 = 5; | |||
There was a problem hiding this comment.
This is only used as a Duration, so maybe just make the constant also a Duration? (Then you don't have to name it "_secs")
There was a problem hiding this comment.
Yeah, I actually did have it that way before but thought it made the callsite using it a bit harder to read with the mapping and unwrapping. I do agree that having a concrete type rather than a suffix is a good idea though. I'll switch it back.
Soak Test ResultsBaseline: 88367ad ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±7.0% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±7.0%: Fine details of change detection per experiment.
Fine details of each soak run.
|
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
github-actions
bot
added
the
domain: sinks
Soak Test ResultsBaseline: b530a9d ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
Fine details of each soak run.
|
Soak Test ResultsBaseline: 3e377cc ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. Changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:
Fine details of change detection per experiment.
Fine details of each soak run.
|
jszwedko
added a commit
that referenced
this pull request
May 4, 2022
…ials (#12422) * fix(aws provider): Allow configuring the load timeout for AWS credentials Technically an enhancement, but it allows working around a regression in behavior (the default changing from 30s to 5s as part of the SDK upgrade) so marking as a fix. Closes: #12421 Signed-off-by: Jesse Szwedko <jesse@szwedko.me> * Fix the rest of the usages Signed-off-by: Jesse Szwedko <jesse@szwedko.me> * Fix test Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically an enhancement, but it allows working around a regression in
behavior (the default changing from 30s to 5s as part of the SDK
upgrade) so marking as a fix.
Closes: #12421
Signed-off-by: Jesse Szwedko jesse@szwedko.me