Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade rust to 1.62.1 #13620

Closed

Conversation

caibirdme
Copy link
Contributor

@caibirdme caibirdme commented Jul 19, 2022

Upgrade rust to 1.62.1 to fix async fn increment build bug

Closes: #13621

@netlify
Copy link

netlify bot commented Jul 19, 2022

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 4602c8b
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/62d6dcee191faf0008142cea

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caibirdme ! Just one note, otherwise looks good.

Cargo.toml Outdated Show resolved Hide resolved
@bruceg bruceg mentioned this pull request Jul 19, 2022
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
@github-actions
Copy link

Soak Test Results

Baseline: 7880784
Comparison: 62bd3bc
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_blackhole_acks 2.81MiB 4.47 100.00% 62.85MiB 6.35MiB 132.14KiB 0 0.100945 65.66MiB 2.49MiB 52.1KiB 0 0.0379093 False False
syslog_regex_logs2metric_ddmetrics 85.87KiB 0.67 100.00% 12.59MiB 704.55KiB 14.35KiB 0 0.0546489 12.67MiB 714.99KiB 14.56KiB 0 0.0550916 False False
http_pipelines_blackhole_acks 7.22KiB 0.6 99.49% 1.18MiB 103.51KiB 2.11KiB 0 0.085773 1.19MiB 72.72KiB 1.48KiB 0 0.0599002 False False
syslog_splunk_hec_logs 82.11KiB 0.46 100.00% 17.3MiB 766.38KiB 15.6KiB 0 0.0432449 17.38MiB 579.96KiB 11.83KiB 0 0.0325744 False False
http_to_http_acks 79.43KiB 0.42 29.26% 18.49MiB 7.37MiB 154.04KiB 0 0.398496 18.57MiB 6.95MiB 145.09KiB 0 0.374484 True True
syslog_humio_logs 63.56KiB 0.35 100.00% 17.63MiB 114.19KiB 2.33KiB 0 0.0063236 17.69MiB 115.81KiB 2.37KiB 0 0.00639063 False False
splunk_hec_route_s3 14.97KiB 0.08 18.40% 19.35MiB 2.22MiB 46.22KiB 0 0.114644 19.36MiB 2.14MiB 44.77KiB 0 0.110567 False False
datadog_agent_remap_blackhole 43.38KiB 0.07 31.13% 64.69MiB 4.02MiB 83.74KiB 0 0.062058 64.73MiB 3.29MiB 68.64KiB 0 0.0508226 False False
splunk_hec_to_splunk_hec_logs_noack 11.3KiB 0.05 69.19% 23.83MiB 431.87KiB 8.82KiB 0 0.0176977 23.84MiB 328.46KiB 6.7KiB 0 0.0134537 False False
enterprise_http_to_http -1.88KiB -0.01 20.80% 23.85MiB 244.84KiB 5.0KiB 0 0.0100244 23.85MiB 249.78KiB 5.11KiB 0 0.0102274 False False
splunk_hec_indexer_ack_blackhole -7.13KiB -0.03 23.27% 23.76MiB 802.38KiB 16.32KiB 0 0.0329746 23.75MiB 871.68KiB 17.73KiB 0 0.0358328 False False
file_to_blackhole -34.95KiB -0.04 26.17% 95.34MiB 3.42MiB 70.98KiB 0 0.0359062 95.3MiB 3.7MiB 76.86KiB 0 0.0387693 False False
splunk_hec_to_splunk_hec_logs_acks -16.91KiB -0.07 51.84% 23.76MiB 799.41KiB 16.27KiB 0 0.0328447 23.75MiB 869.44KiB 17.68KiB 0 0.0357469 False False
http_to_http_json -34.12KiB -0.14 99.26% 23.85MiB 344.56KiB 7.03KiB 0 0.0141082 23.81MiB 520.41KiB 10.62KiB 0 0.0213384 False False
syslog_log2metric_splunk_hec_metrics -42.96KiB -0.23 91.27% 18.18MiB 780.53KiB 15.91KiB 0 0.0419165 18.14MiB 954.68KiB 19.43KiB 0 0.0513875 False False
http_pipelines_blackhole -5.17KiB -0.31 98.80% 1.65MiB 10.26KiB 214.58B 0 0.00606206 1.65MiB 100.39KiB 2.05KiB 0 0.0595101 False False
fluent_elasticsearch -299.21KiB -0.37 100.00% 79.47MiB 53.8KiB 1.09KiB 0 0.000660968 79.18MiB 2.75MiB 56.56KiB 0 0.0347598 False False
http_to_http_noack -112.22KiB -0.46 100.00% 23.84MiB 398.5KiB 8.14KiB 0 0.0163221 23.73MiB 1.17MiB 24.39KiB 0 0.0493112 False False
datadog_agent_remap_datadog_logs_acks -344.01KiB -0.53 99.66% 63.92MiB 3.37MiB 70.46KiB 0 0.0527505 63.58MiB 4.51MiB 93.83KiB 0 0.0708789 False False
syslog_log2metric_humio_metrics -80.67KiB -0.58 100.00% 13.52MiB 243.54KiB 4.97KiB 0 0.0175823 13.45MiB 550.27KiB 11.2KiB 0 0.0399598 False False
socket_to_socket_blackhole -100.63KiB -0.71 100.00% 13.78MiB 117.02KiB 2.39KiB 0 0.00829176 13.68MiB 124.35KiB 2.54KiB 0 0.00887469 False False
datadog_agent_remap_datadog_logs -468.61KiB -0.72 100.00% 63.92MiB 257.5KiB 5.27KiB 0 0.00393298 63.47MiB 3.89MiB 81.13KiB 0 0.061332 False False
syslog_loki -142.37KiB -0.94 100.00% 14.75MiB 212.56KiB 4.36KiB 0 0.0140716 14.61MiB 724.71KiB 14.73KiB 0 0.0484329 False False
http_pipelines_no_grok_blackhole -280.38KiB -2.43 100.00% 11.26MiB 192.5KiB 3.93KiB 0 0.0166949 10.98MiB 1.13MiB 23.59KiB 0 0.103129 False False
http_text_to_http_json -1.57MiB -4.05 100.00% 38.85MiB 1.53MiB 32.02KiB 0 0.0394417 37.28MiB 1.45MiB 30.23KiB 0 0.0387877 False False

@github-actions
Copy link

Soak Test Results

Baseline: 7880784
Comparison: 4602c8b
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_blackhole_acks 852.54KiB 1.28 100.00% 64.98MiB 4.82MiB 100.31KiB 0 0.074129 65.81MiB 3.02MiB 63.21KiB 0 0.0459139 False False
datadog_agent_remap_blackhole 480.61KiB 0.77 99.71% 61.31MiB 5.78MiB 120.47KiB 0 0.0942562 61.78MiB 5.16MiB 107.63KiB 0 0.0834979 False False
syslog_splunk_hec_logs 90.41KiB 0.51 100.00% 17.35MiB 794.87KiB 16.17KiB 0 0.0447322 17.44MiB 559.2KiB 11.41KiB 0 0.0313102 False False
syslog_regex_logs2metric_ddmetrics 63.79KiB 0.48 99.95% 12.98MiB 664.07KiB 13.53KiB 0 0.0499675 13.04MiB 603.91KiB 12.31KiB 0 0.0452238 False False
syslog_humio_logs 83.2KiB 0.46 100.00% 17.57MiB 124.48KiB 2.54KiB 0 0.006916 17.65MiB 117.31KiB 2.4KiB 0 0.00648755 False False
splunk_hec_route_s3 44.79KiB 0.23 48.30% 18.75MiB 2.38MiB 49.65KiB 0 0.127115 18.8MiB 2.3MiB 48.1KiB 0 0.122423 False False
splunk_hec_to_splunk_hec_logs_noack 21.82KiB 0.09 92.30% 23.82MiB 507.59KiB 10.36KiB 0 0.0208099 23.84MiB 328.12KiB 6.7KiB 0 0.0134401 False False
http_pipelines_blackhole_acks 498.9B 0.04 13.71% 1.18MiB 111.65KiB 2.27KiB 0 0.092286 1.18MiB 82.09KiB 1.67KiB 0 0.0678282 False False
enterprise_http_to_http -484.89B -0 5.38% 23.85MiB 242.72KiB 4.95KiB 0 0.00993776 23.85MiB 243.01KiB 4.97KiB 0 0.00995001 False False
splunk_hec_indexer_ack_blackhole -7.64KiB -0.03 24.05% 23.76MiB 845.33KiB 17.2KiB 0 0.0347438 23.75MiB 888.78KiB 18.08KiB 0 0.0365411 False False
file_to_blackhole -35.68KiB -0.04 25.94% 95.34MiB 3.4MiB 70.51KiB 0 0.0356663 95.3MiB 3.92MiB 81.49KiB 0 0.0410918 False False
splunk_hec_to_splunk_hec_logs_acks -8.54KiB -0.04 26.21% 23.75MiB 866.44KiB 17.62KiB 0 0.0356249 23.74MiB 907.78KiB 18.46KiB 0 0.0373377 False False
http_to_http_json -25.92KiB -0.11 96.87% 23.85MiB 344.15KiB 7.02KiB 0 0.0140914 23.82MiB 478.33KiB 9.78KiB 0 0.0196064 False False
syslog_log2metric_splunk_hec_metrics -25.13KiB -0.13 77.33% 19.04MiB 605.56KiB 12.34KiB 0 0.0310487 19.02MiB 821.65KiB 16.73KiB 0 0.0421823 False False
fluent_elasticsearch -254.03KiB -0.31 100.00% 79.47MiB 53.06KiB 1.07KiB 0 0.000651841 79.22MiB 2.24MiB 46.02KiB 0 0.0282567 False False
http_to_http_noack -86.14KiB -0.35 99.98% 23.84MiB 392.11KiB 8.02KiB 0 0.0160613 23.75MiB 1.06MiB 22.03KiB 0 0.0444627 False False
datadog_agent_remap_datadog_logs_acks -286.37KiB -0.44 99.10% 63.94MiB 3.06MiB 63.95KiB 0 0.047816 63.66MiB 4.28MiB 89.05KiB 0 0.0671562 False False
http_pipelines_blackhole -7.96KiB -0.47 99.96% 1.65MiB 9.53KiB 199.47B 0 0.00563604 1.64MiB 110.22KiB 2.25KiB 0 0.0654678 False False
socket_to_socket_blackhole -72.39KiB -0.51 100.00% 13.82MiB 122.16KiB 2.49KiB 0 0.00863287 13.75MiB 127.98KiB 2.61KiB 0 0.00909078 False False
syslog_loki -124.88KiB -0.82 100.00% 14.82MiB 399.05KiB 8.16KiB 0 0.0262888 14.7MiB 734.75KiB 14.94KiB 0 0.0488058 False False
datadog_agent_remap_datadog_logs -632.81KiB -0.96 100.00% 64.15MiB 407.33KiB 8.34KiB 0 0.00619921 63.53MiB 4.4MiB 91.56KiB 0 0.0692033 False False
syslog_log2metric_humio_metrics -141.27KiB -1.04 100.00% 13.32MiB 388.11KiB 7.92KiB 0 0.0284436 13.18MiB 509.1KiB 10.37KiB 0 0.0377006 False False
http_to_http_acks -305.23KiB -1.65 79.11% 18.06MiB 7.98MiB 166.75KiB 0 0.441566 17.76MiB 8.46MiB 176.58KiB 0 0.476249 True True
http_pipelines_no_grok_blackhole -264.6KiB -2.3 100.00% 11.25MiB 189.5KiB 3.87KiB 0 0.0164512 10.99MiB 1.1MiB 22.94KiB 0 0.100267 False False
http_text_to_http_json -1.04MiB -2.65 100.00% 39.41MiB 822.17KiB 16.78KiB 0 0.0203707 38.36MiB 1.21MiB 25.19KiB 0 0.0314102 False False

@jszwedko
Copy link
Member

Replaced by #13667

@jszwedko jszwedko closed this Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Rust 1.62.1 Incremental compilation bug with async fn method capturing multiple lifetimes
3 participants