fix(docker-logs source): old messages that are dropped should be a component_error #14449
Conversation
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
✅ Deploy Preview for vector-project canceled.
|
github-actions
bot
added
the
domain: sources
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
There was a problem hiding this comment.
Not sure I know enough about this source to intelligently debate whether it should be a trace! or an internal event.
I guess the question I have is - when that occurs it looks like we just don't insert a timestamp into the created log event. But it still looks like we process it the same otherwise. 🤔 I guess I'm not totally convinced it is an Error case 🤷
No. If you note when we hit that point there is a |
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Soak Test ResultsBaseline: 9cf1ea9 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
Ah, I missed the |
| @@ -197,7 +197,7 @@ pub struct DockerLogsReceivedOldLogError<'a> { | |||
| impl InternalEvent for DockerLogsReceivedOldLogError<'_> { | |||
| fn emit(self) { | |||
| error!( | |||
| message = "Received older log.", | |||
| message = "Received out of order log message.", | |||
There was a problem hiding this comment.
Small thing but, 💭 Should we update the name of the event to more closely match this? E.g. DockerLogsReceivedOutOfOrderError or just DockerLogsOutOfOrderError ?
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Ref #14411
When receiving a message from docker that is older than the previous one, this message was being dropped and a
tracemessage was emitted.I would argue that this should be a component error, and this PR makes it so.
It's not 100% clear to me under what circumstances this error would occur, so I am open to arguments as to why this should remain a trace - in which case I will update to add a comment with that reason.
Signed-off-by: Stephen Wakely fungus.humungus@gmail.com