-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vrl parse_xml): Fix panic in parse_xml vrl function #14479
fix(vrl parse_xml): Fix panic in parse_xml vrl function #14479
Conversation
✅ Deploy Preview for vector-project canceled.
|
Soak Test ResultsBaseline: 14fefee ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
4d89712
to
934a801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me. Thanks!
Still vulnerable to:
Report:
|
In our company we found a potential panic in
parse_xml
which crashes vector.XML payload causing panic
Payload was found by https://github.com/stasos24
I added test case for this, but I am not sure about it.
According to spec this is incorrect xml
But
roxmltree
parses it without an errorShould we depend on this behavior? If not then test should be removed