fix(datadog_traces sink): APM stats payloads are sent independent of trace payloads and at a set interval. #15084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocumentation. probably going to reorg a bit.
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
domain: ci
✅ Deploy Preview for vrl-playground canceled.
|
neuronull
added
the
ci-condition: integration tests enable
neuronull
changed the title
neuronull
added
sink: datadog_traces
spencergilbert
approved these changes
Nov 3, 2022
Soak Test ResultsBaseline: d620352 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
tobz
previously requested changes
Nov 3, 2022
Regression Test Results
Baseline: cf73729 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Soak Test ResultsBaseline: cf73729 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
tobz
approved these changes
Nov 4, 2022
spencergilbert
approved these changes
Nov 4, 2022
StephenWakely
approved these changes
Nov 5, 2022
Regression Test Results
Baseline: ba02a47 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Soak Test ResultsBaseline: ba02a47 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
davidhuie-dd
pushed a commit
that referenced
this pull request
Nov 7, 2022
…trace payloads and at a set interval. (#15084) - APM stats are now "flushed" in a separate thread, detached from the sink's stream loop. - The stats flushing thread flushes the oldest bucket every 10 seconds, and caches the last two 10 second buckets. - When sink is shutting down, the APM stats thread flushes remaining buckets.
spencergilbert
pushed a commit
that referenced
this pull request
Nov 23, 2022
…trace payloads and at a set interval. (#15084) - APM stats are now "flushed" in a separate thread, detached from the sink's stream loop. - The stats flushing thread flushes the oldest bucket every 10 seconds, and caches the last two 10 second buckets. - When sink is shutting down, the APM stats thread flushes remaining buckets.
jszwedko
pushed a commit
that referenced
this pull request
Nov 28, 2022
…trace payloads and at a set interval. (#15084) - APM stats are now "flushed" in a separate thread, detached from the sink's stream loop. - The stats flushing thread flushes the oldest bucket every 10 seconds, and caches the last two 10 second buckets. - When sink is shutting down, the APM stats thread flushes remaining buckets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer notes:
Behavioral changes:
Refactor (re-organizing only) changes:
stats.rswas up to 1.2k lines of code. That's too much for my sanity. So I reorganized the code to more closely match the Agent's Golang code organization.Manual testing results
The two plotted metrics should be "collapsed" into the same line.
// Agent only (base case)
// Agent -> Vector (before fix)
// Agent -> Vector (after fix)