fix(azure service)!: Retrieve .inner() from SensitiveString for Azure ConnectionString #15225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure_common::config::build_client requires a String not a SensitiveString, in the conversion using to_string() we were accidentally converting to the sensitive value to **REDACTED**. This fixes it by using the same method that seems to have been used in the PR that introduced this change: vectordotdev#14305 to call `.inner()` to retrieve the value from inside the struct and then converts that to a String.
❌ Deploy Preview for vrl-playground failed.
|
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
domain: sinks
Regression Test Results
Baseline: ecdc5ab Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Soak Test ResultsBaseline: ecdc5ab ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. Changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:
Fine details of change detection per experiment.
|
tobz
approved these changes
Nov 16, 2022
tobz
added
the
ci-condition: integration tests enable
|
Woops, realized the integration tests never ran for this PR. Just kicked those off, and that should hopefully be done in 20-30 minutes. |
|
@tobz thanks, it would be great appreciated to get this fix out and released :-) |
spencergilbert
pushed a commit
that referenced
this pull request
Nov 23, 2022
… ConnectionString (#15225) Retrieve .inner() from SensitiveString for Azure ConnectionString azure_common::config::build_client requires a String not a SensitiveString, in the conversion using to_string() we were accidentally converting to the sensitive value to **REDACTED**. This fixes it by using the same method that seems to have been used in the PR that introduced this change: #14305 to call `.inner()` to retrieve the value from inside the struct and then converts that to a String.
|
Just a heads up that this PR doesn't seem to be breaking, but was marked as such with the |
jszwedko
pushed a commit
that referenced
this pull request
Nov 28, 2022
…ConnectionString (#15225) Retrieve .inner() from SensitiveString for Azure ConnectionString azure_common::config::build_client requires a String not a SensitiveString, in the conversion using to_string() we were accidentally converting to the sensitive value to **REDACTED**. This fixes it by using the same method that seems to have been used in the PR that introduced this change: #14305 to call `.inner()` to retrieve the value from inside the struct and then converts that to a String. Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azure_common::config::build_clientrequires a String not a SensitiveString, in the conversion using to_string() we were accidentally converting to the sensitive value to**REDACTED**.This fixes it by using the same method that seems to have been used in the PR that introduced this change: #14305 to call
.inner()to retrieve the value from inside the struct and then converts that to a String.Closes: #15214
Related: