fix(gcp_stackdriver_metrics)!: fixes invalid format for gcp metrics (#14890) #16089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed with manual testing, this does fix compatibility with gcp monitoring. I can push metrics. But there is a side effect. Because this struct is used both for configuration and for calling the gcp API, it changes the structure of the configuration. You need to move the resource labels to a "labels" attribute, like this:
Not sure if that is ok...this sink was totally broken I think, so I guess no one is using it.
I see in the v0.22.0 highlights, it seems this flattening of the labels was intentional.
https://github.com/vectordotdev/vector/blob/master/website/content/en/highlights/2022-05-03-0-22-0-upgrade-guide.md?plain=1#L31
The alternative, to keep the flattened labels in the config, would be to use a different struct for config vs serialization?