Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): Store default value in a box #16487

Merged
merged 6 commits into from
Feb 17, 2023

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Feb 16, 2023

Another baby step towards making configuration schemas object safe. This stores the default value for the config metadata in a box instead of a concrete type. The type bounds on the metadata remain for now, as I'm trying to make this minimal behavior-preserving change before tackling the generic bounds. As far as I can tell from vector generate-schema, the resulting data is identical.

@bruceg bruceg added type: tech debt A code change that does not add user value. domain: config Anything related to configuring Vector labels Feb 16, 2023
@bruceg bruceg requested review from tobz and a team February 16, 2023 23:22
@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 9007e2f
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63eeba9c3cf3a700084201f3
😎 Deploy Preview https://deploy-preview-16487--vector-project.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for vrl-playground ready!

Name Link
🔨 Latest commit 9007e2f
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/63eeba9c1d431500088d7fc1
😎 Deploy Preview https://deploy-preview-16487--vrl-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Feb 16, 2023
@bruceg bruceg added the ci-condition: integration tests enable Run integration tests on this PR label Feb 16, 2023
@github-actions
Copy link

Regression Detector Results

Run ID: 8527b454-7911-4303-9b33-d3568a6e4f3a
Baseline: 6d43f48
Comparison: 9007e2f
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_regex_logs2metric_ddmetrics ingress throughput 155.75KiB/CPU-s 4.29 100.00% 3.55MiB/CPU-s 452.55KiB/CPU-s 5.84KiB/CPU-s 0.0 0.124606 3.7MiB/CPU-s 394.29KiB/CPU-s 5.09KiB/CPU-s 0.0 0.104099 True False
datadog_agent_remap_blackhole ingress throughput 982.8KiB/CPU-s 3.20 100.00% 29.97MiB/CPU-s 2.28MiB/CPU-s 30.18KiB/CPU-s 0.0 0.076199 30.93MiB/CPU-s 879.04KiB/CPU-s 11.34KiB/CPU-s 0.0 0.027755 False False
syslog_loki ingress throughput 261.31KiB/CPU-s 3.04 100.00% 8.4MiB/CPU-s 351.57KiB/CPU-s 4.54KiB/CPU-s 0.0 0.040881 8.65MiB/CPU-s 121.42KiB/CPU-s 1.57KiB/CPU-s 0.0 0.013702 False False
syslog_log2metric_humio_metrics ingress throughput 107.48KiB/CPU-s 1.72 100.00% 6.09MiB/CPU-s 266.55KiB/CPU-s 3.44KiB/CPU-s 0.0 0.042708 6.2MiB/CPU-s 172.48KiB/CPU-s 2.23KiB/CPU-s 0.0 0.027168 False False
http_text_to_http_json ingress throughput 261.8KiB/CPU-s 1.05 100.00% 24.35MiB/CPU-s 636.1KiB/CPU-s 8.21KiB/CPU-s 0.0 0.025508 24.61MiB/CPU-s 616.58KiB/CPU-s 7.96KiB/CPU-s 0.0 0.024468 False False
otlp_http_to_blackhole ingress throughput 11.59KiB/CPU-s 0.76 100.00% 1.48MiB/CPU-s 124.42KiB/CPU-s 1.61KiB/CPU-s 0.0 0.081888 1.5MiB/CPU-s 130.77KiB/CPU-s 1.69KiB/CPU-s 0.0 0.085414 False False
socket_to_socket_blackhole ingress throughput 48.01KiB/CPU-s 0.36 100.00% 13.19MiB/CPU-s 183.49KiB/CPU-s 2.37KiB/CPU-s 0.0 0.013588 13.23MiB/CPU-s 182.01KiB/CPU-s 2.35KiB/CPU-s 0.0 0.013431 False False
otlp_grpc_to_blackhole ingress throughput 2.62KiB/CPU-s 0.25 99.67% 1.02MiB/CPU-s 40.66KiB/CPU-s 537.52B/CPU-s 0.0 0.038981 1.02MiB/CPU-s 55.63KiB/CPU-s 735.04B/CPU-s 0.0 0.053198 False False
http_to_http_json ingress throughput 32.15KiB/CPU-s 0.23 100.00% 13.59MiB/CPU-s 255.5KiB/CPU-s 3.3KiB/CPU-s 0.0 0.018357 13.62MiB/CPU-s 212.13KiB/CPU-s 2.74KiB/CPU-s 0.0 0.015206 False False
syslog_log2metric_splunk_hec_metrics ingress throughput 18.41KiB/CPU-s 0.20 99.55% 8.94MiB/CPU-s 388.93KiB/CPU-s 5.02KiB/CPU-s 0.0 0.042483 8.96MiB/CPU-s 316.43KiB/CPU-s 4.09KiB/CPU-s 0.0 0.034494 False False
syslog_splunk_hec_logs ingress throughput 17.53KiB/CPU-s 0.20 99.98% 8.65MiB/CPU-s 220.84KiB/CPU-s 2.85KiB/CPU-s 0.0 0.024939 8.66MiB/CPU-s 283.22KiB/CPU-s 3.65KiB/CPU-s 0.0 0.031921 False False
enterprise_http_to_http ingress throughput 10.46KiB/CPU-s 0.08 96.40% 13.61MiB/CPU-s 335.45KiB/CPU-s 4.33KiB/CPU-s 0.0 0.024065 13.62MiB/CPU-s 191.8KiB/CPU-s 2.48KiB/CPU-s 0.0 0.013749 False False
http_to_http_noack ingress throughput 2.1KiB/CPU-s 0.02 29.87% 13.61MiB/CPU-s 311.39KiB/CPU-s 4.02KiB/CPU-s 0.0 0.022335 13.62MiB/CPU-s 288.43KiB/CPU-s 3.72KiB/CPU-s 0.0 0.020685 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput 3.46KiB/CPU-s 0.02 64.56% 13.62MiB/CPU-s 217.77KiB/CPU-s 2.81KiB/CPU-s 0.0 0.01561 13.63MiB/CPU-s 190.44KiB/CPU-s 2.46KiB/CPU-s 0.0 0.013648 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput 2.91KiB/CPU-s 0.02 34.24% 13.62MiB/CPU-s 370.35KiB/CPU-s 4.78KiB/CPU-s 0.0 0.026559 13.62MiB/CPU-s 348.92KiB/CPU-s 4.5KiB/CPU-s 0.0 0.025017 False False
fluent_elasticsearch ingress throughput 120.18B/CPU-s 0.00 17.10% 45.41MiB/CPU-s 30.47KiB/CPU-s 398.15B/CPU-s 0.0 0.000655 45.41MiB/CPU-s 29.76KiB/CPU-s 388.89B/CPU-s 0.0 0.00064 False False
splunk_hec_indexer_ack_blackhole ingress throughput -188.24B/CPU-s -0.00 3.21% 13.62MiB/CPU-s 249.82KiB/CPU-s 3.22KiB/CPU-s 0.0 0.017913 13.62MiB/CPU-s 251.12KiB/CPU-s 3.24KiB/CPU-s 0.0 0.018007 False False
file_to_blackhole ingress throughput -13.61KiB/CPU-s -0.02 47.34% 54.5MiB/CPU-s 1.12MiB/CPU-s 14.76KiB/CPU-s 0.0 0.020502 54.48MiB/CPU-s 1.18MiB/CPU-s 15.62KiB/CPU-s 0.0 0.021726 False False
datadog_agent_remap_datadog_logs ingress throughput -70.72KiB/CPU-s -0.21 99.90% 32.87MiB/CPU-s 1.1MiB/CPU-s 14.55KiB/CPU-s 0.0 0.033525 32.8MiB/CPU-s 1.21MiB/CPU-s 15.92KiB/CPU-s 0.0 0.036755 False False
http_to_http_acks ingress throughput -20.27KiB/CPU-s -0.37 30.61% 5.3MiB/CPU-s 2.76MiB/CPU-s 36.41KiB/CPU-s 0.0 0.519863 5.28MiB/CPU-s 2.76MiB/CPU-s 36.42KiB/CPU-s 0.0 0.521959 True False
datadog_agent_remap_datadog_logs_acks ingress throughput -144.42KiB/CPU-s -0.43 100.00% 32.5MiB/CPU-s 1.25MiB/CPU-s 16.52KiB/CPU-s 0.0 0.038488 32.36MiB/CPU-s 822.87KiB/CPU-s 10.62KiB/CPU-s 0.0 0.024834 False False
syslog_humio_logs ingress throughput -109.66KiB/CPU-s -1.22 100.00% 8.77MiB/CPU-s 221.6KiB/CPU-s 2.86KiB/CPU-s 0.0 0.024671 8.66MiB/CPU-s 293.97KiB/CPU-s 3.8KiB/CPU-s 0.0 0.033133 False False
splunk_hec_route_s3 ingress throughput -151.53KiB/CPU-s -1.28 100.00% 11.56MiB/CPU-s 546.87KiB/CPU-s 7.05KiB/CPU-s 0.0 0.046184 11.41MiB/CPU-s 525.77KiB/CPU-s 6.78KiB/CPU-s 0.0 0.044978 False False
datadog_agent_remap_blackhole_acks ingress throughput -516.11KiB/CPU-s -1.65 100.00% 30.63MiB/CPU-s 1.05MiB/CPU-s 13.85KiB/CPU-s 0.0 0.03419 30.13MiB/CPU-s 1.38MiB/CPU-s 18.25KiB/CPU-s 0.0 0.045808 False False

@bruceg bruceg merged commit 59ab0da into master Feb 17, 2023
@bruceg bruceg deleted the bruceg/config-box-default-value branch February 17, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-condition: integration tests enable Run integration tests on this PR domain: config Anything related to configuring Vector domain: sinks Anything related to the Vector's sinks type: tech debt A code change that does not add user value.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants