Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws service): Revert AWS-SDK updates #16651

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

spencergilbert
Copy link
Contributor

Closes #16629

Nathan and I tracked this down to a (possible) bug in the SDK, pending resolution/information upstream reverting the changes to the last known-good version we have.

@spencergilbert spencergilbert requested a review from a team March 1, 2023 20:13
@spencergilbert spencergilbert added the ci-condition: integration tests enable Run integration tests on this PR label Mar 1, 2023
@spencergilbert spencergilbert self-assigned this Mar 1, 2023
@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit 611bfb8
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/63ffb1d7bf72d0000842f6d2

@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 611bfb8
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63ffb1d7dbb1610008343eb5
😎 Deploy Preview https://deploy-preview-16651--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added domain: ci Anything related to Vector's CI environment domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources labels Mar 1, 2023
@@ -7,7 +7,6 @@ services:
image: docker.io/localstack/localstack-full:0.11.6
environment:
- SERVICES=kinesis,s3,cloudwatch,elasticsearch,es,firehose,sqs
- DEBUG=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could keep this / reintroduce it separately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, truthfully it wasn't particularly useful either but it did log something

@spencergilbert spencergilbert enabled auto-merge (squash) March 1, 2023 20:24
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Regression Detector Results

Run ID: 488f96c5-4de0-4a41-83bf-7345a133fb36
Baseline: 47c22a5
Comparison: 611bfb8
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
file_to_blackhole egress throughput 208.15KiB/CPU-s 2.89 76.39% 7.03MiB/CPU-s 3.79MiB/CPU-s 124.6KiB/CPU-s 0.0 0.539212 7.24MiB/CPU-s 3.7MiB/CPU-s 123.77KiB/CPU-s 0.0 0.511092 True False
syslog_splunk_hec_logs ingress throughput 234.37KiB/CPU-s 2.66 100.00% 8.61MiB/CPU-s 347.29KiB/CPU-s 4.27KiB/CPU-s 0.0 0.03939 8.84MiB/CPU-s 305.68KiB/CPU-s 3.76KiB/CPU-s 0.0 0.033773 False False
datadog_agent_remap_datadog_logs ingress throughput 795.87KiB/CPU-s 2.41 100.00% 32.24MiB/CPU-s 1.25MiB/CPU-s 15.8KiB/CPU-s 0.0 0.038882 33.02MiB/CPU-s 1.09MiB/CPU-s 13.68KiB/CPU-s 0.0 0.032881 False False
splunk_hec_route_s3 ingress throughput 208.22KiB/CPU-s 1.76 100.00% 11.55MiB/CPU-s 613.99KiB/CPU-s 7.55KiB/CPU-s 0.0 0.051888 11.76MiB/CPU-s 536.2KiB/CPU-s 6.6KiB/CPU-s 0.0 0.04453 False False
syslog_regex_logs2metric_ddmetrics ingress throughput 56.7KiB/CPU-s 1.57 100.00% 3.52MiB/CPU-s 464.72KiB/CPU-s 5.72KiB/CPU-s 0.0 0.128833 3.58MiB/CPU-s 358.41KiB/CPU-s 4.41KiB/CPU-s 0.0 0.097822 True False
datadog_agent_remap_blackhole_acks ingress throughput 208.82KiB/CPU-s 0.65 100.00% 31.44MiB/CPU-s 974.74KiB/CPU-s 11.99KiB/CPU-s 0.0 0.030274 31.64MiB/CPU-s 700.78KiB/CPU-s 8.63KiB/CPU-s 0.0 0.021625 False False
syslog_loki ingress throughput 44.27KiB/CPU-s 0.51 100.00% 8.5MiB/CPU-s 279.33KiB/CPU-s 3.44KiB/CPU-s 0.0 0.032092 8.54MiB/CPU-s 373.69KiB/CPU-s 4.6KiB/CPU-s 0.0 0.042717 False False
http_text_to_http_json ingress throughput 43.24KiB/CPU-s 0.17 99.98% 24.98MiB/CPU-s 679.68KiB/CPU-s 8.37KiB/CPU-s 0.0 0.026568 25.02MiB/CPU-s 653.28KiB/CPU-s 8.04KiB/CPU-s 0.0 0.025493 False False
enterprise_http_to_http ingress throughput 1.59KiB/CPU-s 0.01 34.18% 13.62MiB/CPU-s 222.43KiB/CPU-s 2.74KiB/CPU-s 0.0 0.015947 13.62MiB/CPU-s 188.75KiB/CPU-s 2.32KiB/CPU-s 0.0 0.013531 False False
fluent_elasticsearch ingress throughput 404.01B/CPU-s 0.00 55.50% 45.41MiB/CPU-s 29.88KiB/CPU-s 372.31B/CPU-s 0.0 0.000643 45.41MiB/CPU-s 30.16KiB/CPU-s 375.73B/CPU-s 0.0 0.000648 False False
splunk_hec_indexer_ack_blackhole ingress throughput -523.82B/CPU-s -0.00 9.01% 13.62MiB/CPU-s 257.42KiB/CPU-s 3.17KiB/CPU-s 0.0 0.018462 13.62MiB/CPU-s 262.04KiB/CPU-s 3.22KiB/CPU-s 0.0 0.018794 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput 5.34B/CPU-s 0.00 0.07% 13.61MiB/CPU-s 341.84KiB/CPU-s 4.2KiB/CPU-s 0.0 0.02452 13.61MiB/CPU-s 342.13KiB/CPU-s 4.21KiB/CPU-s 0.0 0.024541 False False
http_to_http_noack ingress throughput -626.75B/CPU-s -0.00 8.75% 13.61MiB/CPU-s 320.72KiB/CPU-s 3.95KiB/CPU-s 0.0 0.023005 13.61MiB/CPU-s 319.15KiB/CPU-s 3.93KiB/CPU-s 0.0 0.022893 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput -3.06KiB/CPU-s -0.02 50.25% 13.62MiB/CPU-s 248.62KiB/CPU-s 3.06KiB/CPU-s 0.0 0.017828 13.61MiB/CPU-s 268.97KiB/CPU-s 3.31KiB/CPU-s 0.0 0.019292 False False
syslog_log2metric_humio_metrics ingress throughput -3.62KiB/CPU-s -0.06 63.26% 6.2MiB/CPU-s 259.28KiB/CPU-s 3.19KiB/CPU-s 0.0 0.040824 6.2MiB/CPU-s 197.54KiB/CPU-s 2.43KiB/CPU-s 0.0 0.031119 False False
http_to_http_json ingress throughput -37.17KiB/CPU-s -0.27 100.00% 13.62MiB/CPU-s 218.86KiB/CPU-s 2.69KiB/CPU-s 0.0 0.015691 13.58MiB/CPU-s 273.38KiB/CPU-s 3.36KiB/CPU-s 0.0 0.019653 False False
datadog_agent_remap_blackhole ingress throughput -129.1KiB/CPU-s -0.40 100.00% 31.58MiB/CPU-s 895.98KiB/CPU-s 11.02KiB/CPU-s 0.0 0.027706 31.45MiB/CPU-s 701.16KiB/CPU-s 8.63KiB/CPU-s 0.0 0.021769 False False
http_to_http_acks ingress throughput -21.57KiB/CPU-s -0.40 33.78% 5.3MiB/CPU-s 2.77MiB/CPU-s 34.89KiB/CPU-s 0.0 0.521757 5.28MiB/CPU-s 2.77MiB/CPU-s 34.94KiB/CPU-s 0.0 0.52472 True False
otlp_grpc_to_blackhole ingress throughput -6.96KiB/CPU-s -0.65 100.00% 1.04MiB/CPU-s 55.2KiB/CPU-s 695.75B/CPU-s 0.0 0.051879 1.03MiB/CPU-s 44.41KiB/CPU-s 559.64B/CPU-s 0.0 0.042015 False False
syslog_humio_logs ingress throughput -88.39KiB/CPU-s -0.98 100.00% 8.81MiB/CPU-s 265.13KiB/CPU-s 3.26KiB/CPU-s 0.0 0.029384 8.72MiB/CPU-s 319.27KiB/CPU-s 3.93KiB/CPU-s 0.0 0.035735 False False
otlp_http_to_blackhole ingress throughput -21.63KiB/CPU-s -1.35 100.00% 1.57MiB/CPU-s 105.16KiB/CPU-s 1.29KiB/CPU-s 0.0 0.065392 1.55MiB/CPU-s 106.42KiB/CPU-s 1.31KiB/CPU-s 0.0 0.067077 False False
syslog_log2metric_splunk_hec_metrics ingress throughput -132.51KiB/CPU-s -1.39 100.00% 9.28MiB/CPU-s 233.56KiB/CPU-s 2.87KiB/CPU-s 0.0 0.024577 9.15MiB/CPU-s 451.4KiB/CPU-s 5.55KiB/CPU-s 0.0 0.048171 False False
datadog_agent_remap_datadog_logs_acks ingress throughput -479.51KiB/CPU-s -1.41 100.00% 33.28MiB/CPU-s 1.05MiB/CPU-s 13.25KiB/CPU-s 0.0 0.031609 32.81MiB/CPU-s 1.56MiB/CPU-s 19.66KiB/CPU-s 0.0 0.047554 False False
socket_to_socket_blackhole ingress throughput -247.89KiB/CPU-s -1.87 100.00% 12.98MiB/CPU-s 513.36KiB/CPU-s 6.32KiB/CPU-s 0.0 0.038625 12.74MiB/CPU-s 547.45KiB/CPU-s 6.74KiB/CPU-s 0.0 0.041973 False False

@spencergilbert spencergilbert merged commit 90ae9f7 into master Mar 1, 2023
@spencergilbert spencergilbert deleted the spencer/revert-aws-sdk-updates branch March 1, 2023 21:46
jszwedko pushed a commit that referenced this pull request Mar 3, 2023
* Revert "chore(deps): upgrade AWS crates to v0.54.1 (#16443)"

This reverts commit 0d084c2.

* Revert "chore(deps): Update aws-sdks to 0.23 and aws supporting crates to 0.53 (#16365)"

This reverts commit f4e90e1.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
fuchsnj added a commit that referenced this pull request Mar 10, 2023
* chore(kafka): revert make consumer group instance id configurable (#16580)

Reverts: #15869

This reverts commit f90ca9e.

* fix(pulsar sink): Rename batch size option (#16582)

* fix(pulsar sink): Rename batch size option

To be consistent with other sink batch options.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* Update src/sinks/pulsar.rs

Co-authored-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>

---------

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Co-authored-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>

* chore(releasing): Prepare v0.28.0 release

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* chore(releasing): Fix tag detection

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* chore(releasing): Add known issues for 0.28.0. (#16649)

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* chore(website): Add a links to footer for to the /releases and /downloads pages (#16441)

* attempt to add header

* Remove from header, add to footer and release pages

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* Remove extra whitespace

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

---------

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* fix(aws service): Revert AWS-SDK updates (#16651)

* Revert "chore(deps): upgrade AWS crates to v0.54.1 (#16443)"

This reverts commit 0d084c2.

* Revert "chore(deps): Update aws-sdks to 0.23 and aws supporting crates to 0.53 (#16365)"

This reverts commit f4e90e1.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* fix(socket source): remove default_max_length default (#16631)

* Remove default_max_length default

Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>

* Remove default_max_length default from unix

Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>

* Update configurable docs

Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>

---------

Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>

* chore(releasing): Prepare v0.28.1 release

Co-authored-by: neuronull <neuronull@pm.me>
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* save

* save

* save

* save

* save

* update more versions

* save

* cleanup

* revert MSRV

* fix formatting

* revert version back to 1.66.1

---------

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Co-authored-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
Co-authored-by: neuronull <neuronull@pm.me>
Co-authored-by: Stephen Wakely <fungus.humungus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-condition: integration tests enable Run integration tests on this PR domain: ci Anything related to Vector's CI environment domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting "Healthcheck failed" error when use aws_cloudwatch_logs component
2 participants