chore(vdev): Rewrite package-msi.sh to vdev #16748
Conversation
jonathanpv
added
platform: windows
✅ Deploy Preview for vrl-playground canceled.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
✅ Deploy Preview for vector-project canceled.
|
jonathanpv
changed the title
github-actions
bot
added
domain: ci
|
In We would like to utilize cargo vdev publish msi given that with |
Regression Detector ResultsRun ID: 272ecc38-bb0a-4560-8a3c-57934e424daa ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
I believe that should work yes. The |
I see yeah it does look like we used cargo vdev version inside of the script. So this should work. I pushed the commit implementing this. |
…er, improve comments
Regression Detector ResultsRun ID: f5aa7242-4d1d-4aea-bfa0-a2bcd8150994 ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
Regression Detector ResultsRun ID: 83c3d200-f055-4a8a-8b1c-c68ccd10b2a1 ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
| let mut license_rtf_file = File::create("LICENSE.rtf")?; | ||
| writeln!( | ||
| license_rtf_file, | ||
| "{{\\rtf1\\ansi\\ansicpg1252\\deff0\\nouicompat{{\\fonttbl{{\\f0\\fnil\\fcharset0 Lucida Console;}}}}\n\\viewkind4\\uc1\n\\pard\\f0\\fs14\\lang1033\\par" |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
Regression Detector ResultsRun ID: e52e3b6f-18cb-48dd-91f4-69a2f097331e ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
|
Just a note that this may conflict with https://github.com/vectordotdev/vector/pull/16281/files#diff-1db1d87549a6fdaf4d5c9325481bbc90ef363d92d05c2685d4e7e4777478415d depending on which goes in first. |
| let powershell_command = format!( | ||
| "$progressPreference = 'silentlyContinue'; Expand-Archive {zip_file}" | ||
| ); | ||
| app::exec("powershell", ["-Command", &powershell_command], false)?; |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
Regression Detector ResultsRun ID: 9733a8a8-9080-4a12-872e-d83f5f483973 ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
jonathanpv
changed the title
Regression Detector ResultsRun ID: 0bd334a2-5d8d-4765-bdf7-1f59972f61da ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
| println!("Running Build with args: {archive_version}"); | ||
| println!("Copying ZIP archive..."); | ||
|
|
There was a problem hiding this comment.
I know these status messages were copied from the original script, but I don't think they inform anything.
There was a problem hiding this comment.
I removed this in my local branch and will push shortly
| "-var var.VectorDir", | ||
| "-out components.wxs" | ||
| ]; | ||
| Command::new("heat").args(args).capture_output()?; |
There was a problem hiding this comment.
Since we don't use the output, and any messages from this command (and below) would end up being thrown away by this, I think you want check_run here:
| Command::new("heat").args(args).capture_output()?; | |
| Command::new("heat").args(args).check_run()?; |
There was a problem hiding this comment.
Implemented locally and will push
Problem
We would like to rewrite the package-msi.sh script to native Rust in vdev
Solution
package-msi.shand commented each script line I translated to Rustpackagesubcommand for vdev in a folder structurepackage/mod.rsandpackage/msi.rsTesting
cargo vdev package msiRelated Issues
vdevto native code #16383Checklist