chore(vdev): Rewrite release-homebrew into vdev #16772
Conversation
jonathanpv
added
platform: homebrew
✅ Deploy Preview for vector-project canceled.
|
✅ Deploy Preview for vrl-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
domain: ci
|
I feel like this PR is the closest I've come to nailing it on the first try. I think my experience with vdev has helped me get better at writing code that meets the project's standards, and I've been able to respond more quickly to feedback from previous PRs. Definitely feeling more confident in my abilities and excited to keep improving |
Regression Detector ResultsRun ID: 6887ace7-f7d2-4932-ae6d-e1b8efc71a74 ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:
Fine details of change detection per experiment.
|
Regression Detector ResultsRun ID: 49c38410-b764-4c55-ab17-9ff0cb038b8c ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
|
@jonathanpv is this still waiting for anything? Or can we merge it in? |
whoops sorry didn't know there was a reply waiting here. Nothing to wait on was very focused on the windows environment and neglected this at the moment. Is there a better way to parse through github comments and notifications? I get spammed on my email for failing jobs and its quite cumbersome to go through it all when theres only actionable things to do on a few notifications. |
No worries :D Dealing with GitHub notifications effectively is challenging. One thing you might find useful would be to look at GitHub's notification center: https://github.com/notifications?query=is%3Aunread . There there are some useful filters to find actionable notifications. |
|
This needed to be modified to include the recent changes of capture_output to check_output. It now prints the exit codes of the failing git functions. Error: Command: "git" "config" "user.name" "vic" "user.email" "vector@datadoghq.com"
failed with exit code: 129
output:I made this fail on the git::push() function in homebrew.rs by setting an invalid |
Datadog ReportBranch report: ❌ ❌ Failed Tests (1)
|
Regression Detector ResultsRun ID: 9371de44-9d6b-4381-9412-77121232913a ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
Regression Detector ResultsRun ID: 19ae9499-f339-4afc-973a-2a08caccdf09 ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
Problem
We would like to rewrite the release-homebrew.sh script to native Rust in vdev
Solution
release-homebrew.shinto vdev release subcommandrelease-homebrew.shTesting
cargo vdev release homebrewRelated Issues
vdevto native code #16383Checklist