Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): ignore .helix dir #17203

Merged
merged 1 commit into from
Apr 24, 2023
Merged

chore(dev): ignore .helix dir #17203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ cargo-timing*.html
.DS_Store
.idea/
.vscode/
.helix/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the biggest deal, especially since there is precedent here already, but I like to think of .gitignore only have project-specific ignore patterns and that users can configure their global gitignore config to ignore environment / editor specific files. This avoids the need to add ignore patterns to every project that one interacts with.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good philosophy to follow. I didn't think about that when I saw the vscode one...
I'm happy to remove it!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 given we have vscode and idea in there already, if we remove helix I'd suggest removing those two as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened #17267

.dir-locals.el
checkpoints/*
miniodat
Expand Down