Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): support Datadog metric origin metadata #18405

Merged
merged 36 commits into from
Sep 20, 2023
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
56443fd
add the new origin metadata to the EventMetadata
neuronull Aug 21, 2023
93fa1fa
set OriginService in log_to_metric transform
neuronull Aug 22, 2023
46850c9
decode unknown protobuf fields with protofish
neuronull Aug 23, 2023
b2f97ec
experiment with parsing the Origin metadata field by specifying in th…
neuronull Aug 24, 2023
cc7b317
start adding the metadata to the series in dd metrics sink
neuronull Aug 25, 2023
6914fa9
add logic for setting the non-pass through metadata in dd metrics sink
neuronull Aug 25, 2023
01e170a
add tests, implement for sketches
neuronull Aug 25, 2023
6c1f388
touch up
neuronull Aug 25, 2023
c95cefc
cleanup
neuronull Aug 28, 2023
7122f29
doc
neuronull Aug 28, 2023
7953d8c
typo
neuronull Aug 28, 2023
4ea935d
fix transform unit tests
neuronull Aug 28, 2023
319ec8d
check events
neuronull Aug 28, 2023
a4d721c
remove internal/deprecated fields
neuronull Aug 29, 2023
cc163f6
docs
neuronull Aug 29, 2023
1ca2f9d
Merge branch 'master' into neuronull/feat_metrics_origin
neuronull Aug 29, 2023
a912fe5
feedback ds: static str
neuronull Aug 30, 2023
a24ebe4
feedback ds and js
neuronull Aug 30, 2023
5df328e
delete
neuronull Aug 30, 2023
d4de720
review feedback
neuronull Sep 8, 2023
9761139
pass origin metadata in vector proto
neuronull Sep 8, 2023
0e3d2b6
Merge branch 'master' into neuronull/feat_metrics_origin
neuronull Sep 11, 2023
0167110
fix issue with native codec unit test. add breaking change deprecatio…
neuronull Sep 12, 2023
1236503
check fmt/markdown
neuronull Sep 12, 2023
e46319b
restore json
neuronull Sep 12, 2023
b64f5b0
Revert "restore json"
neuronull Sep 12, 2023
b4190b2
make metric series proto backwards compatible
neuronull Sep 13, 2023
332d5b6
comment out test for functionality that is broken
neuronull Sep 13, 2023
a1d1016
check events
neuronull Sep 13, 2023
e91754b
update patch files
neuronull Sep 14, 2023
3d5696d
Revert "make metric series proto backwards compatible"
neuronull Sep 14, 2023
a49391e
Merge branch 'master' into neuronull/feat_metrics_origin
neuronull Sep 14, 2023
900464c
add the GH issue to the TODO
neuronull Sep 14, 2023
9cf0847
whitespace in proto
neuronull Sep 14, 2023
f591d76
gitattribute
dsmith3197 Sep 15, 2023
60aacfa
feedback
dsmith3197 Sep 19, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check events
neuronull committed Aug 28, 2023
commit 319ec8d8f138c57603ff2b7a21d7ebec47311c41
4 changes: 2 additions & 2 deletions src/sinks/datadog/metrics/encoder.rs
Original file line number Diff line number Diff line change
@@ -445,7 +445,7 @@ fn sketch_to_proto_message(
event_metadata.source_type(),
);

debug!("generated sketch metadata: {:?}", metadata);
debug!("Generated sketch metadata: {:?}", metadata);
neuronull marked this conversation as resolved.
Show resolved Hide resolved

ddmetric_proto::sketch_payload::Sketch {
metric: name,
@@ -641,7 +641,7 @@ fn generate_series_metrics(
event_metadata.source_type(),
);

debug!("generated series metadata: {:?}", metadata);
debug!("Generated series metadata: {:?}", metadata);
neuronull marked this conversation as resolved.
Show resolved Hide resolved

let results = match (metric.value(), metric.interval_ms()) {
(MetricValue::Counter { value }, maybe_interval_ms) => {
2 changes: 1 addition & 1 deletion src/sources/datadog_agent/metrics.rs
Original file line number Diff line number Diff line change
@@ -241,7 +241,7 @@ fn get_event_metadata(metadata: Option<&Metadata>) -> EventMetadata {
.as_ref()
.map_or(EventMetadata::default(), |origin| {
debug!(
neuronull marked this conversation as resolved.
Show resolved Hide resolved
"Deserialized origin_product: `{}` origin_category: `{}` origin_service: `{}`",
"Deserialized origin_product: `{}` origin_category: `{}` origin_service: `{}`.",
origin.origin_product, origin.origin_category, origin.origin_service
);
EventMetadata::default().with_origin_metadata(