Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Replace atty with is-terminal #18966

Closed
wants to merge 1 commit into from

Conversation

jszwedko
Copy link
Member

atty seems to be unmaintained and vulnerable to GHSA-g98v-hv3f-hcfr.
I followed clap's lead and replaced with is-termianl
(clap-rs/clap#4249).

Signed-off-by: Jesse Szwedko jesse.szwedko@datadoghq.com

`atty` seems to be unmaintained and vulnerable to GHSA-g98v-hv3f-hcfr.
I followed `clap`'s lead and replaced with `is-termianl`
(clap-rs/clap#4249).

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko jszwedko requested a review from a team October 27, 2023 19:40
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit f27a475
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/653c121c48e65500089fca51

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit f27a475
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/653c121cdc3dae0008d06a58
😎 Deploy Preview https://deploy-preview-18966--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the domain: vdev Anything related to the vdev tooling label Oct 27, 2023
@jszwedko jszwedko enabled auto-merge October 27, 2023 19:40
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/replace-atty
Commit report: c1c30b6

vector: 0 Failed, 0 New Flaky, 1998 Passed, 0 Skipped, 1m 22.05s Wall Time

@jszwedko jszwedko added this pull request to the merge queue Oct 27, 2023
@github-actions
Copy link

Regression Detector Results

Run ID: 2fed13e1-eeb6-4486-84e9-203b03e46e83
Baseline: 3b85b48
Comparison: 8b43363
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
file_to_blackhole egress throughput +1.13 [-1.36, +3.63] 54.51%
datadog_agent_remap_blackhole ingress throughput +0.85 [+0.76, +0.93] 100.00%
http_text_to_http_json ingress throughput +0.79 [+0.66, +0.92] 100.00%
datadog_agent_remap_blackhole_acks ingress throughput +0.64 [+0.55, +0.73] 100.00%
datadog_agent_remap_datadog_logs_acks ingress throughput +0.30 [+0.23, +0.37] 100.00%
fluent_elasticsearch ingress throughput +0.16 [-0.28, +0.61] 45.10%
syslog_humio_logs ingress throughput +0.14 [+0.05, +0.23] 99.08%
http_to_s3 ingress throughput +0.12 [-0.16, +0.40] 51.83%
http_to_http_noack ingress throughput +0.07 [-0.01, +0.15] 83.55%
http_to_http_json ingress throughput +0.05 [-0.02, +0.12] 73.70%
splunk_hec_indexer_ack_blackhole ingress throughput +0.01 [-0.13, +0.14] 5.85%
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.14, +0.14] 2.24%
http_to_http_acks ingress throughput -0.03 [-1.35, +1.28] 3.24%
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.05 [-0.17, +0.06] 57.26%
splunk_hec_route_s3 ingress throughput -0.13 [-0.64, +0.37] 33.37%
otlp_http_to_blackhole ingress throughput -0.16 [-0.31, -0.01] 91.97%
enterprise_http_to_http ingress throughput -0.16 [-0.23, -0.08] 99.94%
syslog_loki ingress throughput -0.40 [-0.44, -0.36] 100.00%
otlp_grpc_to_blackhole ingress throughput -0.41 [-0.51, -0.30] 100.00%
datadog_agent_remap_datadog_logs ingress throughput -0.43 [-0.52, -0.35] 100.00%
syslog_regex_logs2metric_ddmetrics ingress throughput -0.67 [-0.75, -0.58] 100.00%
syslog_log2metric_splunk_hec_metrics ingress throughput -0.90 [-1.02, -0.77] 100.00%
syslog_splunk_hec_logs ingress throughput -0.96 [-1.00, -0.91] 100.00%
socket_to_socket_blackhole ingress throughput -1.37 [-1.44, -1.30] 100.00%
syslog_log2metric_humio_metrics ingress throughput -1.99 [-2.09, -1.88] 100.00%

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 27, 2023
jszwedko added a commit that referenced this pull request Oct 30, 2023
Turns out this is in the stdlib now.

Replaces: #18966

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko
Copy link
Member Author

Replaced with #18985

@jszwedko jszwedko closed this Oct 30, 2023
github-merge-queue bot pushed a commit that referenced this pull request Nov 1, 2023
Turns out this is in the stdlib now.

Replaces: #18966

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
Turns out this is in the stdlib now.

Replaces: vectordotdev#18966

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: vdev Anything related to the vdev tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants