Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): Detail the format of DEPRECATIONS.md file #19016

Merged
merged 4 commits into from
Nov 2, 2023
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions docs/DEPRECATIONS.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,23 @@
See [DEPRECATION.md](docs/DEPRECATION.md#process) for the process for updating this file.

The format for each entry should be: `<version> <identifier> <description>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to add an example

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, added.


- `<version>` should be the version of Vector in which to take the action (deprecate, migrate, or
remove)
- `<identifier>` should be a unique identifier that can also be used in the code to easily find the
places to modify
- `<description>` should be a longer form description of the change to be made

For example:

- legacy_openssl_provider v0.34.0 OpenSSL legacy provider flag should be removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version and identifier should be swapped right?

Suggested change
- legacy_openssl_provider v0.34.0 OpenSSL legacy provider flag should be removed
- v0.34.0 legacy_openssl_provider OpenSSL legacy provider flag should be removed


## To be deprecated

## To be migrated

## To be removed

* Support for `v1` series endpoint in the `datadog_metrics` sink should be removed.
* legacy_openssl_provider v0.34.0 OpenSSL legacy provider flag should be removed
* armv7_rpm v0.34.0 The armv7 RPM packages should be removed (replaced by armv7hl)
- Support for `v1` series endpoint in the `datadog_metrics` sink should be removed.
- legacy_openssl_provider v0.34.0 OpenSSL legacy provider flag should be removed
- armv7_rpm v0.34.0 The armv7 RPM packages should be removed (replaced by armv7hl)
Loading