chore: List checks to be run prior to submitting a PR in CONTRIBUTING.md
#19118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
StephenWakely
changed the title
CONTRIBUTING.mdCONTRIBUTING.md
pront
reviewed
Nov 10, 2023
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
jszwedko
approved these changes
Nov 10, 2023
It has been suggested, but the push back was that different people would have different sets of commands they want to run. However, if there is now a recommended set, it would seem to be more desirable. |
FWIW this is what we ended up doing for VRL:
|
pront
approved these changes
Nov 10, 2023
pront
pushed a commit
to dygfloyd/vector
that referenced
this pull request
Nov 15, 2023
…G.md` (vectordotdev#19118) * Add other CI jobs to CONTRIBUTING.md Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Mention cargo fmt Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Link to clippy Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Make checks copy pasteable Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Reduce line length Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Remove urls Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> --------- Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
AndrooTheChen
pushed a commit
to discord/vector
that referenced
this pull request
Sep 23, 2024
…G.md` (vectordotdev#19118) * Add other CI jobs to CONTRIBUTING.md Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Mention cargo fmt Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Link to clippy Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Make checks copy pasteable Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Reduce line length Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Remove urls Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> --------- Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't see this mentioned anywhere else. This adds a list of checks that should be run before submitting a PR to the
CONTRIBUTING.mddocs.