Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): improve source data_dir docs #19596

Merged
merged 3 commits into from
Jan 12, 2024
Merged

chore(docs): improve source data_dir docs #19596

merged 3 commits into from
Jan 12, 2024

Conversation

pront
Copy link
Member

@pront pront commented Jan 11, 2024

No description provided.

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 11, 2024
@pront pront requested review from a team as code owners January 11, 2024 19:58
@pront pront requested a review from a team January 11, 2024 19:58
@github-actions github-actions bot added domain: sources Anything related to the Vector's sources domain: external docs Anything related to Vector's external, public documentation labels Jan 11, 2024
Copy link

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

Copy link

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Jan 11, 2024

Datadog Report

Branch report: pront/data-dir-docs
Commit report: d2e2f97
Test service: vector

✅ 0 Failed, 2092 Passed, 0 Skipped, 1m 25s Wall Time

src/sources/file.rs Outdated Show resolved Hide resolved
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pront pront enabled auto-merge January 12, 2024 15:17
@pront pront requested a review from a team January 12, 2024 15:50
@pront pront force-pushed the pront/data-dir-docs branch from 29b0d29 to e3fdf66 Compare January 12, 2024 16:56
@pront pront added this pull request to the merge queue Jan 12, 2024
Copy link

Regression Detector Results

Run ID: 846afa6b-5b84-47d4-88da-2346c84de847
Baseline: e1d570d
Comparison: f262324
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_regex_logs2metric_ddmetrics ingress throughput +3.48 [+3.34, +3.61]
http_to_http_acks ingress throughput +1.33 [+0.01, +2.64]
file_to_blackhole egress throughput +1.19 [-1.35, +3.73]
otlp_http_to_blackhole ingress throughput +1.00 [+0.86, +1.15]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.98 [+0.89, +1.07]
syslog_loki ingress throughput +0.95 [+0.90, +1.00]
datadog_agent_remap_datadog_logs ingress throughput +0.57 [+0.49, +0.65]
socket_to_socket_blackhole ingress throughput +0.56 [+0.49, +0.64]
splunk_hec_route_s3 ingress throughput +0.42 [-0.07, +0.90]
syslog_humio_logs ingress throughput +0.39 [+0.30, +0.49]
http_to_http_noack ingress throughput +0.11 [+0.02, +0.20]
datadog_agent_remap_blackhole_acks ingress throughput +0.03 [-0.05, +0.12]
http_to_http_json ingress throughput +0.02 [-0.05, +0.10]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.15]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.16, +0.16]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.01 [-0.12, +0.10]
http_elasticsearch ingress throughput -0.01 [-0.08, +0.06]
syslog_log2metric_humio_metrics ingress throughput -0.03 [-0.14, +0.07]
otlp_grpc_to_blackhole ingress throughput -0.04 [-0.13, +0.04]
enterprise_http_to_http ingress throughput -0.13 [-0.21, -0.06]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.19 [-0.31, -0.07]
http_to_s3 ingress throughput -0.24 [-0.52, +0.03]
fluent_elasticsearch ingress throughput -0.54 [-1.01, -0.08]
syslog_splunk_hec_logs ingress throughput -0.96 [-1.03, -0.88]
http_text_to_http_json ingress throughput -1.05 [-1.18, -0.92]
datadog_agent_remap_blackhole ingress throughput -1.13 [-1.24, -1.03]
syslog_log2metric_splunk_hec_metrics ingress throughput -1.46 [-1.60, -1.31]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit f262324 Jan 12, 2024
39 of 41 checks passed
@pront pront deleted the pront/data-dir-docs branch January 12, 2024 20:21
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
* chore(docs): improve source data_dir docs

* fix doc content

* regen docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: sources Anything related to the Vector's sources no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants