Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(file sink): Upgrade file sink for tokio-compat #1988

Merged
merged 30 commits into from
Mar 19, 2020
Merged

chore(file sink): Upgrade file sink for tokio-compat #1988

merged 30 commits into from
Mar 19, 2020
+620 −478

Commits on Mar 19, 2020

  1. Revert "Disable file sink and files bench" 

    This reverts commit dd5c922.

Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    0de147b View commit details
    Browse the repository at this point in the history

  2. Upgrade file sink for tokio 0.2 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    16260b2 View commit details
    Browse the repository at this point in the history

  3. Further StreamingSink to refactoring 

    - switch StreamingSink to impl Stream - provides a significant boot to
  composability;
- simpler compat layer - this compat approach should be much easier to
  understand, it consists of a set of simple and documented components
  that are composed together in a meaningful way;
- switch tests to directly working with FileSink instead of futures
  compat layer - this build upon on StreamingSink taking impl Stream
  instead of mpsc::Receiver.

Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    40cf84c View commit details
    Browse the repository at this point in the history

  4. Corrected tracing 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    ee53620 View commit details
    Browse the repository at this point in the history

  5. Extracted event processing logic to a separate function 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    e622ff1 View commit details
    Browse the repository at this point in the history

  6. Switch from futures::future::select to tokio02::select! 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    4d87cd5 View commit details
    Browse the repository at this point in the history

  7. Make ExpiringHashMap Unpin 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    fa1d43d View commit details
    Browse the repository at this point in the history

  8. Move ?Sized to where clause 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    f21e382 View commit details
    Browse the repository at this point in the history

  9. Simplified the ExpiringHashMap API 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    42e0563 View commit details
    Browse the repository at this point in the history

  10. Unify item kind at ExpiringHashMap::remove and ExpiringHashMap::poll_… 

    …expired

Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    0e9a3c7 View commit details
    Browse the repository at this point in the history

  11. Move ExpiringHashMap to expiring_hash_map/mod.rs 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    3aa371a View commit details
    Browse the repository at this point in the history

  12. Add some tests 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    2eb8419 View commit details
    Browse the repository at this point in the history

  13. Add insert_waker, make tests pass 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    65b95b9 View commit details
    Browse the repository at this point in the history

  14. Add another test 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    565cb15 View commit details
    Browse the repository at this point in the history

  15. Improved value assertion test 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    e09e8ee View commit details
    Browse the repository at this point in the history

  16. Add wake count tests 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    6f335c5 View commit details
    Browse the repository at this point in the history

  17. Simplify compat, get rid of UnitTypeErrorSink01 in favor of sink_map_err 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    a3fb117 View commit details
    Browse the repository at this point in the history

  18. Eliminate useless log message 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    df961bc View commit details
    Browse the repository at this point in the history

  19. Switch FileSink to impl Future instead of Stream 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    c68bdbc View commit details
    Browse the repository at this point in the history

  20. Upgrade tokio for sync::Notify 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    0a15df1 View commit details
    Browse the repository at this point in the history

  21. Implemented an API that we settled on with Lucio 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    a0048c2 View commit details
    Browse the repository at this point in the history

  22. Add docs 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    4f98750 View commit details
    Browse the repository at this point in the history

  23. Better comment at the example 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    e6dcbe9 View commit details
    Browse the repository at this point in the history

  24. Make StreamingSink::run's input 'static 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    2ea84bc View commit details
    Browse the repository at this point in the history

  25. Remove .get_ref() from ?path 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    3fecdd3 View commit details
    Browse the repository at this point in the history

  26. Correct typos and grammar errors at the docs 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    33ae750 View commit details
    Browse the repository at this point in the history

  27. Documented the unreachable! branch 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    448c2fe View commit details
    Browse the repository at this point in the history

  28. Move expiring_hash_map tests mod into it's main file 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    f1f4258 View commit details
    Browse the repository at this point in the history

  29. Compacted nesting 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    9e4a0e4 View commit details
    Browse the repository at this point in the history

  30. Fix the typos at the streaming sink compat docs 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    d5b8f44 View commit details
    Browse the repository at this point in the history