Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Drop use of infer crate #21623

Merged
merged 3 commits into from
Oct 28, 2024
Merged

chore(deps): Drop use of infer crate #21623

merged 3 commits into from
Oct 28, 2024
+42 −23

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Oct 25, 2024

No description provided.

@bruceg bruceg added type: tech debt A code change that does not add user value. dependencies Pull requests that update a dependency file no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Oct 25, 2024
@bruceg bruceg requested a review from a team as a code owner October 25, 2024 20:11
@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Oct 25, 2024
pront
pront reviewed Oct 25, 2024
View reviewed changes
src/sources/aws_kinesis_firehose/handlers.rs Outdated
}
}
}
}

fn is_gzip(data: &[u8]) -> bool {
data.len() > 8 && &data[..3] == b"\x1f\x8b\x08"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these magic bytes defined in an RFC? I think a link to the spec would be useful here.

@bruceg bruceg requested a review from pront October 25, 2024 20:30
pront
pront approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bruceg!

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Oct 25, 2024 •
edited
Loading

Datadog Report

Branch report: bruceg/drop-infer
Commit report: 361fef3
Test service: vector

✅ 0 Failed, 87 Passed, 0 Skipped, 4m 5.63s Total Time

@bruceg bruceg enabled auto-merge October 25, 2024 20:52
@bruceg bruceg added this pull request to the merge queue Oct 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 26, 2024
@bruceg bruceg added this pull request to the merge queue Oct 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 27, 2024
@bruceg bruceg added this pull request to the merge queue Oct 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 28, 2024
@pront pront added this pull request to the merge queue Oct 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2024
@bruceg bruceg added this pull request to the merge queue Oct 28, 2024
Merged via the queue into master with commit 29d58c9 Oct 28, 2024
41 checks passed
@bruceg bruceg deleted the bruceg/drop-infer branch October 28, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pront pront pront approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file domain: sources Anything related to the Vector's sources no-changelog Changes in this PR do not need user-facing explanations in the release changelog type: tech debt A code change that does not add user value.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruceg @pront