Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump rdkafka from 0.35.0 to 0.37.0 #21929

Merged
merged 2 commits into from
Dec 12, 2024
Merged

chore(deps): Bump rdkafka from 0.35.0 to 0.37.0 #21929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b30cd43
chore(deps): Bump rdkafka from 0.35.0 to 0.37.0
dependabot[bot] Dec 2, 2024
85e90b8
chore(deps): Bump rdkafka from 0.35.0 to 0.37.0 (#22023)
sam6258 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 5 additions & 26 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ postgres-openssl = { version = "0.5.0", default-features = false, features = ["r
pulsar = { version = "6.3.0", default-features = false, features = ["tokio-runtime", "auth-oauth2", "flate2", "lz4", "snap", "zstd"], optional = true }
rand.workspace = true
rand_distr = { version = "0.4.3", default-features = false }
rdkafka = { version = "0.35.0", default-features = false, features = ["curl-static", "tokio", "libz", "ssl", "zstd"], optional = true }
rdkafka = { version = "0.37.0", default-features = false, features = ["curl-static", "tokio", "libz", "ssl", "zstd"], optional = true }
redis = { version = "0.24.0", default-features = false, features = ["connection-manager", "tokio-comp", "tokio-native-tls-comp"], optional = true }
regex = { version = "1.11.1", default-features = false, features = ["std", "perf"] }
roaring = { version = "0.10.7", default-features = false, features = ["std"], optional = true }
Expand Down
10 changes: 3 additions & 7 deletions src/sources/kafka.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ use futures::{Stream, StreamExt};
use futures_util::future::OptionFuture;
use rdkafka::{
consumer::{
stream_consumer::StreamPartitionQueue, CommitMode, Consumer, ConsumerContext, Rebalance,
StreamConsumer,
stream_consumer::StreamPartitionQueue, BaseConsumer, CommitMode, Consumer, ConsumerContext,
Rebalance, StreamConsumer,
},
error::KafkaError,
message::{BorrowedMessage, Headers as _, Message},
Expand Down Expand Up @@ -1369,15 +1369,11 @@ impl ClientContext for KafkaSourceContext {
}

impl ConsumerContext for KafkaSourceContext {
fn pre_rebalance(&self, rebalance: &Rebalance) {
fn pre_rebalance(&self, _base_consumer: &BaseConsumer<Self>, rebalance: &Rebalance) {
match rebalance {
Rebalance::Assign(tpl) => self.consume_partitions(tpl),

Rebalance::Revoke(tpl) => {
// TODO workaround for https://github.com/fede1024/rust-rdkafka/issues/681
if tpl.capacity() == 0 {
return;
}
self.revoke_partitions(tpl);
self.commit_consumer_state();
}
Expand Down
Loading