-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(greptimedb_metrics sink): fix greptimedb examples #21984
chore(greptimedb_metrics sink): fix greptimedb examples #21984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sunng87 !
@jszwedko Thank you for fast response! I have a question. My idea is to change default value of this My idea is to:
Do you think this will work? Do you have similar practice at Vector before? |
Hey! Yes, something like that would work. It matches the deprecation process we have documented. See the deprecation process documentation for more details on the process. |
Head branch was pushed to by a user without write access
For https://github.com/vectordotdev/vector/actions/runs/12247198112/job/34178224846?pr=21984:
|
Head branch was pushed to by a user without write access
@pront Thank you! It seems example is not allowed for bool fields |
* docs: fix greptimedb example * ci: add greptimedb sinks to semantic ci * fix: remove examples for bool field
Summary
This patch updates examples of
greptimedb_metrics
gzip_compression
new_naming
endpoint
Change Type
Is this a breaking change?
How did you test this PR?
N/A
Does this PR include user facing changes?
Checklist
Cargo.lock
), pleaserun
dd-rust-license-tool write
to regenerate the license inventory and commit the changes (if any). More details here.References