Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): update publicsuffix to use newer idna #21996

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(dev): update publicsuffix to use newer idna #21996

merged 1 commit into from
Dec 10, 2024

Conversation

pront
Copy link
Member

@pront pront commented Dec 10, 2024

Summary

publicsuffix is one of the few deps that use idna
https://rustsec.org/advisories/RUSTSEC-2024-0421

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@pront pront requested a review from a team as a code owner December 10, 2024 01:26
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: pront/update-idna
Commit report: 6f326cd
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.44s Total Time

@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Dec 10, 2024
@jszwedko jszwedko added this pull request to the merge queue Dec 10, 2024
@jszwedko jszwedko mentioned this pull request Dec 10, 2024
Merged
10 tasks
Merged via the queue into master with commit 6dbe5da Dec 10, 2024
57 of 59 checks passed
@jszwedko jszwedko deleted the pront/update-idna branch December 10, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

Assignees
No one assigned
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pront @jszwedko