Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): remove some unused deps #22021

Merged
merged 2 commits into from
Dec 12, 2024
Merged

chore(deps): remove some unused deps #22021

merged 2 commits into from
Dec 12, 2024

Conversation

pront
Copy link
Member

@pront pront commented Dec 11, 2024 •
edited
Loading

Summary

Guided by cargo machete

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Ran all features workflow.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@github-actions github-actions bot added domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: vdev Anything related to the vdev tooling labels Dec 11, 2024
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Dec 11, 2024
pront
pront commented Dec 11, 2024
View reviewed changes
Copy link
Member Author

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-component-features

@pront pront force-pushed the pront/delete-some-unused-deps branch from fc70024 to 6adbfd8 Compare December 11, 2024 23:23
pront
pront commented Dec 11, 2024
View reviewed changes
Copy link
Member Author

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-component-features

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Dec 11, 2024 •
edited
Loading

Datadog Report

Branch report: pront/delete-some-unused-deps
Commit report: d2a561a
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.45s Total Time

@pront pront marked this pull request as ready for review December 12, 2024 01:43
@pront pront requested a review from a team as a code owner December 12, 2024 01:43
jszwedko
jszwedko reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI, and in particular /ci-run-component-features passes 👍

@neuronull previously tried this in #19327 and ran into a wall though.

@pront
Copy link
Member Author

pront commented Dec 12, 2024

If CI, and in particular /ci-run-component-features passes 👍

It passed. There were some problems with deps used in macros so I left those in.

pront
pront commented Dec 12, 2024
View reviewed changes
Copy link
Member Author

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-component-features

@pront
Copy link
Member Author

pront commented Dec 12, 2024

https://github.com/vectordotdev/vector/actions/runs/12298944271

@pront pront enabled auto-merge December 12, 2024 17:34
@pront pront requested a review from jszwedko December 12, 2024 17:34
@pront pront added this pull request to the merge queue Dec 12, 2024
@jszwedko jszwedko mentioned this pull request Dec 12, 2024
Closed
Merged via the queue into master with commit 08bb46f Dec 12, 2024
71 checks passed
@pront pront deleted the pront/delete-some-unused-deps branch December 12, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

Assignees
No one assigned
Labels
domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: vdev Anything related to the vdev tooling no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pront @jszwedko