chore: Remove retry until after timeout test #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Turnbull <james@lovedthanlost.net>
jamtur01
added
domain: tests
…_log_and_metric Signed-off-by: James Turnbull <james@lovedthanlost.net>
leebenson
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
Removal looks fine for now. It's possible other #[should_panic] tests could suffer this same fate on macOS until the cause is rooted out. Tracking in #4056.
Possibly related: rust-lang/rust#74820
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes test until #4003 can be fixed.
Signed-off-by: James Turnbull james@lovedthanlost.net