enhancement(codecs, exec source): Integrate Decoder/DecodingConfig with exec source
#9337
Conversation
Signed-off-by: Pablo Sichert <mail@pablosichert.com>
|
✔️ Deploy Preview for vector-project ready! 🔨 Explore the source changes: d4ef439 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/6156bc83650db50007dbd915 😎 Browse the preview: https://deploy-preview-9337--vector-project.netlify.app |
pablosichert
changed the title
Decoder/DecodingConfig with exec sourceDecoder/DecodingConfig with exec source
pablosichert
changed the title
Decoder/DecodingConfig with exec sourceDecoder/DecodingConfig with exec source
src/sources/exec/mod.rs
Outdated
| send_error = true; | ||
| break; |
There was a problem hiding this comment.
Fun fact: you could add a label the outer loop (e.g. 'outer: while ...) and then break 'outer here instead of using the flag. Not sure if I'd actually recommend it, but maybe?
There was a problem hiding this comment.
Ah yeah, I like that! I think I have tried that before, but had some issues with labels on blocks being unstable or clippy complaining that a loop doesn't actually loop. Seems to work in this case, though
Signed-off-by: Pablo Sichert <mail@pablosichert.com>
…s-exec-codec-integration Signed-off-by: Pablo Sichert <mail@pablosichert.com>
| #[serde(default = "default_events_per_line")] | ||
| pub event_per_line: bool, |
There was a problem hiding this comment.
@lukesteensen @pablosichert removal of this option should have caused this PR to be marked as a backwards incompatible change and noted in the upgrade guide for the next release
@pablosichert do you mind adding it to the upgrade guide for 0.17.0?
Usage of `sized_bytes_codec` was removed in <vectordotdev#9337>. Signed-off-by: Hugo Hromic <hhromic@gmail.com>
Usage of `sized_bytes_codec` was removed in <#9337>. Signed-off-by: Hugo Hromic <hhromic@gmail.com>
Usage of `sized_bytes_codec` was removed in <#9337>. Signed-off-by: Hugo Hromic <hhromic@gmail.com>
Closes #9336.