chore(releasing): Remove -Clink-self-contained=no from musl builds
#9771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in c7da80a but seems to break builds of Rust 1.56.0 with: ``` = note: /usr/local/bin/../lib/gcc/arm-linux-musleabihf/6.4.0/../../../../arm-linux-musleabihf/bin/ld: cannot find -lunwind collect2: error: ld returned 1 exit status ``` I think this is because of these changes in Rust in 1.56.0: rust-lang/rust@4c9896f#diff-b78a4729cc6ec9756d0e89273cb5d1b0bb906264d7d5ed5aa6f759ad07d47c62 It isn't immediately clear to me why we can't have Rust build the libraries to link in so opening this for feedback and to see if it works for all of our cross builds. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
|
✔️ Deploy Preview for vector-project canceled. 🔨 Explore the source changes: 00891fc 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/617317b24159820008c6f797 |
|
@japaric Apologies to bother. I'm just curious if you remember why or if this was needed. |
|
rust-lang/rust#85751 seems possibly relevant. |
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
blt
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in c7da80a but seems to break builds of Rust 1.56.0
with:
I think this is because of these changes in Rust in 1.56.0: rust-lang/rust#85600 . Previously it looks to me that Rust always build libunwind, and now it conditionally does it based on
link-self-contained.It isn't immediately clear to me why we can't have Rust build the libraries to
link in so opening this for feedback and to see if it works for all of our
cross builds.