share only the bytes block

vectordotdev · Dec 9, 2024 · 28a1452 · 28a1452
1 parent 3ff97ae
commit 28a1452
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/stdlib/parse_float.rs b/src/stdlib/parse_float.rs
@@ -1,8 +1,8 @@
 use crate::compiler::prelude::*;
-use crate::stdlib::to_float::to_float;
+use crate::stdlib::to_float::{bytes_to_float};
 
 fn parse_float(value: Value) -> Resolved {
-    to_float(value)
+    bytes_to_float(value.try_bytes()?)
 }
 
 #[derive(Clone, Copy, Debug)]
@@ -127,7 +127,7 @@ mod tests {
 
         nan {
             args: func_args![value: "Nan"],
-            want: Err("NaN number not supported".to_string()),
+            want: Err("NaN number not supported \"Nan\"".to_string()),
             tdef: TypeDef::float().fallible(),
         }
 

diff --git a/src/stdlib/to_float.rs b/src/stdlib/to_float.rs
@@ -1,7 +1,13 @@
 use crate::compiler::conversion::Conversion;
 use crate::compiler::prelude::*;
 
-pub(crate) fn to_float(value: Value) -> Resolved {
+pub(crate) fn bytes_to_float(bytes: Bytes) -> Resolved {
+    Conversion::Float
+        .convert(bytes)
+        .map_err(|e| e.to_string().into())
+}
+
+fn to_float(value: Value) -> Resolved {
     use Value::{Boolean, Bytes, Float, Integer, Null, Timestamp};
     match value {
         Float(_) => Ok(value),