fix(convert): return error when conversion exceeds f64 bounds #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pront
reviewed
Nov 4, 2024
changelog.d/1107.fix.md
Outdated
| @@ -0,0 +1,2 @@ | |||
| Fixes the `to_float` function to return an error instead of "infinity" when parsing a string outside | |||
There was a problem hiding this comment.
Replace fix in the file name with breaking.
src/compiler/conversion/mod.rs
Outdated
| @@ -159,6 +159,11 @@ impl Conversion { | |||
| let parsed = s | |||
| .parse::<f64>() | |||
| .with_context(|_| FloatParseSnafu { s: s.clone() })?; | |||
| if parsed.is_infinite() { | |||
There was a problem hiding this comment.
This is quite nuanced, but I think the least surprising behavior is to use https://doc.rust-lang.org/std/primitive.f64.html#method.is_normal here.
|
Hi @dhable, thank you for this contribution. Do you plan to drive this PR to completion? Let me know if I can help. |
|
@pront Yes, I just got back from PTO but I'll get the suggestions added. |
Prior to this commit, string values that would exceed the f64 bounds would return `f64::INFINITY`. This leaks a type into the VRL scripts that could cause a panic without support to check for the value. Fixes vectordotdev#1107 Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, string values that would exceed the f64 bounds would return
f64::INFINITY. This leaks a type into the VRL scripts that could cause a panic without support to check for the value.Fixes #1107
Summary
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool writeand commit the changes. More details here.References