Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stdlib): fix typo in parse_float and add one test case #1180

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

pront
Copy link
Member

@pront pront commented Dec 6, 2024

Summary

A couple of small fixes that can be reviewed in isolation.

After #1179,
I will followup to address #1120.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

References

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Dec 6, 2024
@pront pront enabled auto-merge December 6, 2024 19:16
@pront pront requested a review from jszwedko December 6, 2024 19:16
@pront pront changed the title fix(stdlib): fix typo in parse_float and add one test case chore(stdlib): fix typo in parse_float and add one test case Dec 6, 2024
@pront pront requested a review from bfung December 6, 2024 19:37
@pront pront added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 32633c1 Dec 6, 2024
17 of 19 checks passed
@pront pront deleted the pront/parse-float branch December 6, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants