feat: give access to the program result type definition #262
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencergilbert
approved these changes
May 31, 2023
lib/fuzz/src/main.rs
Outdated
| let type_state = result.program.final_type_state(); | ||
| let expected_kind = type_state.external.target_kind(); | ||
| let type_state = result.program.final_type_info(); | ||
| let expected_kind = type_state.state.external.target_kind(); |
There was a problem hiding this comment.
non-blocking nit: another ...state.state call here that looks awkward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #240
The type definition of both the result and target of VRL programs is known, but only the target was exposed to users. This gives access to both. It is a minor breaking change.
This is useful for things such as Vector VRL conditions to be able to verify at compile time that programs return a boolean. It will also help with fuzz testing.