Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(diagnostics): improve fallibility assignment error message #560

Merged
merged 1 commit into from
Nov 14, 2023
Merged

feat(diagnostics): improve fallibility assignment error message #560

merged 1 commit into from
Nov 14, 2023

Conversation

pront
Copy link
Member

@pront pront commented Nov 14, 2023

closes: #23

@pront pront requested a review from jszwedko November 14, 2023 15:02
jszwedko
jszwedko approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I think this is a great improvement.

@pront pront added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit fcd395e Nov 14, 2023
11 checks passed
@pront pront deleted the pront/assignment-fallibility-improvement-no2 branch November 14, 2023 20:42
@jszwedko jszwedko mentioned this pull request Nov 28, 2023
Open
@fuchsnj fuchsnj changed the title feat(diagnostics): improve fallibility assignment error feat(diagnostics): improve fallibility assignment error message Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add note to error diagnostics when fallibility is due to function arguments
2 participants
@pront @jszwedko