Add uuid_from_friendly_id function #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszwedko
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Nice work @andrewthad ! I'm impressed that you jumped into Rust to implement it.
A left some notes, but a couple of other requests:
- Could you add a changelog entry? See https://github.com/vectordotdev/vrl/blob/main/changelog.d/README.md
- Can you add a benchmark? See https://github.com/vectordotdev/vrl/blob/main/benches/stdlib.rs
- After this is merged could you open a follow-up PR on https://github.com/vectordotdev/vector to document the new function? See feat(vrl): add
uuid_v7function vector#20048 for an example
Co-authored-by: Jesse Szwedko <jesse@szwedko.me>
Co-authored-by: Jesse Szwedko <jesse@szwedko.me>
auto-merge was automatically disabled
April 19, 2024 20:25
Head branch was pushed to by a user without write access
andrewthad
force-pushed
the
uuid_from_friendly_id
branch
from
f70fc30 to
d57bcd8
Compare
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
|
@andrewthad I pushed a few more tiny fixes. I figured that was faster than pointing them out to you. |
|
Thanks! Looks good to me. |
|
@andrewthad merged! Do you think you'd be able to open a follow-up PR on https://github.com/vectordotdev/vector to document the new function? See vectordotdev/vector#20048 for an example |
|
I've opened a PR for that at vectordotdev/vector#20357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #799
I've never written any Rust code before, so I recommend reviewing this carefully. It includes a passing test.