[OPA-1889] Fix some of the remaining grok discrepancies #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-dd
added
the
no-changelog
pront
reviewed
Jun 24, 2024
pront
reviewed
Jun 24, 2024
vladimir-dd
commented
Jun 25, 2024
| { | ||
| let tz = tz.as_str(); | ||
| let tz: Tz = tz.parse().map_err(|error| { | ||
| let original_value = String::from_utf8_lossy(value.as_bytes().ok_or_else(|| { |
There was a problem hiding this comment.
The only real changes here is adjust_strp_format_and_value() function below.
neuronull
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of the found grok discrepancies/bugs, comparing to Datadog grok parser:
datematcher - assume the current date, year when the time format does not include them.keyvaluefilter - treat extracted fields as paths:db.operationmeans{ "db": { "operation": "insert" }}Value:Nullvalues from the parsed object