Fix issues using DummyGameLocator
with libraries
#175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1:
DummyGameLocator#gameLibraries()
returns a closedStream
As
Stream
isAutoCloseable
, the stream returned byDummyGameLocator
'sgameLibraries()
method was getting closed immediately after the try-catch block. This resulted in the following error:This
IllegalStateException
is being thrown here: https://github.com/JetBrains/jdk8u_jdk/blob/master/src/share/classes/java/nio/file/FileTreeIterator.java#L102-L103, as the stream is already closed.Issue #2: Incorrect
.jar
extension check.endsWith()
onPath
has some interesting semantics, and doesn't just match a suffix on the file name like we're expecting it to. Changing to.toString().endsWith()
fixes this.