Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mosaico: loosen restrictions on required fields #490

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

monishdeb
Copy link
Contributor

Currently, when building a mailing, you must complete all required fields on the first step of the wizard before you can advance to the builder step. It's not uncommon for one person to be tasked with building out the content for an email, and someone else be responsible for building the recipient list. But those first-step requirements create a problem if the first person to create the email is the content builder. With the traditional builder, you can work on the content as soon as you create the email, and can save it without filling in other required fields. The required fields are only necessary in order to advance to the scheduling step. This patch is to make Mosaico work in similar way

@monishdeb
Copy link
Contributor Author

needs core PR civicrm/civicrm-core#22818

@monishdeb
Copy link
Contributor Author

@colemanw @lcdservices can you please review this patch !!

@colemanw
Copy link
Contributor

Ok, I've merged the core PR, and I checked that the permission is being added clientside (CRM.checkPerm doesn't automatically have access to every permission, you have to add them from the .ang.php file) here:

https://github.com/civicrm/civicrm-core/blob/6960dd4c1e5e99f8e0b3564dcc15269184d7702d/ang/crmMailing.ang.php#L15-L24

@mattwire
Copy link
Collaborator

@monishdeb Needs rebase

@colemanw
Copy link
Contributor

@mattwire good to merge

@mattwire mattwire merged commit 31083be into veda-consulting-company:2.x Feb 28, 2022
@monishdeb
Copy link
Contributor Author

Thank you @colemanw and @mattwire

@colemanw colemanw deleted the non-requireness branch March 11, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants